-
Notifications
You must be signed in to change notification settings - Fork 6
Adding pending task section on course info page #78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Adding pending task section on course info page #78
Conversation
|
Thanks for the pull request, @jacobo-dominguez-wgu! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
fc51419 to
0aa1bce
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #78 +/- ##
==========================================
+ Coverage 0.00% 81.06% +81.06%
==========================================
Files 5 27 +22
Lines 7 169 +162
Branches 0 31 +31
==========================================
+ Hits 0 137 +137
- Misses 7 32 +25 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Description
This pr adds the section of Pending Tasks into the Course Info Tab to display the ongoing report generation tasks, in case of no tasks in progress it displays a "No tasks currently running" message.
Most of the code was created here #74, added the reference to the component in the Course info page.
Supporting information
Closes #26
Testing instructions
npm install && npm run devPOST
http://local.openedx.io:8000/courses/:courseId:/instructor/api/list_instructor_taskswith this response data:Best Practices Checklist
We're trying to move away from some deprecated patterns in this codebase. Please
check if your PR meets these recommendations before asking for a review:
.ts,.tsx).propTypes,defaultProps, andinjectIntlpatterns are not used in any new or modified code.src/testUtils.tsx(specificallyinitializeMocks)apiHooks.tsin this repo for examples.messages.tsfiles have adescriptionfor translators to use.../. To import from parent folders, use@src, e.g.import { initializeMocks } from '@src/testUtils';instead offrom '../../../../testUtils'