-
Notifications
You must be signed in to change notification settings - Fork 56
feat: Transfer frontend-template-application improvements #944
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
filippovskii09
wants to merge
9
commits into
openedx:master
Choose a base branch
from
raccoongang:filippovskii/feat/transfer-frontend-template-application-improvements
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
e5e40d8
feat: Transfer frontend-template-application improvements
filippovskii09 723138e
fix: fix disscusions and some refactor
filippovskii09 bb232ae
fix: correct header and footer packeges placement
filippovskii09 3a3d7e9
fix: fix spacing
filippovskii09 b64bc28
fix: ci fix for stylelint
filippovskii09 8d6b34a
fix: add correct changes for packages
filippovskii09 c269569
fix: fix lint errors
filippovskii09 c4ab311
fix: add correct eslint config
filippovskii09 dc71441
fix: remove extra package and fix jest config
filippovskii09 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| coverage/* | ||
| dist/ | ||
| node_modules/ | ||
| jest.config.js | ||
| jest.config.ts |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -17,3 +17,5 @@ temp/babel-plugin-react-intl | |
| *~ | ||
| /temp | ||
| /.vscode | ||
|
|
||
| webpack.dev-tutor.config.js | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| { | ||
| "extends": ["@edx/stylelint-config-edx"], | ||
| "rules": { | ||
| "selector-pseudo-class-no-unknown": [true, { | ||
| "ignorePseudoClasses": ["export"] | ||
| }], | ||
| "unit-no-unknown": [true, { | ||
| "ignoreUnits": ["\\.5"] | ||
| }], | ||
| "property-no-vendor-prefix": [true, { | ||
| "ignoreProperties": ["animation", "filter", "transform", "transition"] | ||
| }], | ||
| "value-no-vendor-prefix": [true, { | ||
| "ignoreValues": ["fill-available"] | ||
| }], | ||
| "function-no-unknown": null, | ||
| "number-leading-zero": "never", | ||
| "no-descending-specificity": null, | ||
| "selector-class-pattern": null, | ||
| "scss/no-global-function-names": null, | ||
| "color-hex-case": "upper", | ||
| "color-hex-length": "long", | ||
| "scss/dollar-variable-empty-line-before": null, | ||
| "scss/dollar-variable-colon-space-after": "at-least-one-space", | ||
| "at-rule-no-unknown": null, | ||
| "scss/at-rule-no-unknown": true, | ||
| "scss/at-import-partial-extension": null, | ||
| "scss/comment-no-empty": null, | ||
| "import-notation": "string", | ||
| "property-no-unknown": [true, { | ||
| "ignoreProperties": ["xs", "sm", "md", "lg", "xl", "xxl"] | ||
| }], | ||
| "alpha-value-notation": "number" | ||
| } | ||
| } |
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| const { createConfig } = require('@openedx/frontend-build'); | ||
|
|
||
| module.exports = createConfig( | ||
| 'eslint', | ||
| { | ||
| rules: { | ||
| 'jsx-a11y/label-has-associated-control': [2, { | ||
| controlComponents: ['Input'], | ||
| }], | ||
| 'template-curly-spacing': 'off', | ||
| 'react-hooks/exhaustive-deps': 'off', | ||
| 'no-restricted-exports': 'off', | ||
| // There is no reason to disallow this syntax anymore; we don't use regenerator-runtime in new browsers | ||
| 'no-restricted-syntax': 'off', | ||
| }, | ||
| }, | ||
| ); | ||
|
|
||
| export {}; |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I took this configuration for
.stylelintrc.jsonfrom this PR openedx/frontend-app-catalog#2There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this the correct link openedx/edx-platform#37480?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you're right, incorrect link, changed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[inform]: @bydawen is currently working on creating a separate issue to address the linter-related questions that came up during this discussion: openedx/frontend-app-catalog#2 (comment). So in the future, we might have fewer overrides and more unified configurations.