Nav3 #191
Open
Nav3 #191
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
florent37
reviewed
Sep 3, 2025
...tion/src/androidDeviceTest/kotlin/io/github/openflocon/navigation/ExampleInstrumentedTest.kt
Outdated
Show resolved
Hide resolved
florent37
reviewed
Sep 3, 2025
...top/navigation/src/androidHostTest/kotlin/io/github/openflocon/navigation/ExampleUnitTest.kt
Outdated
Show resolved
Hide resolved
florent37
reviewed
Sep 3, 2025
florent37
reviewed
Sep 3, 2025
| @@ -0,0 +1,16 @@ | |||
| package io.github.openflocon.navigation | |||
|
|
|||
| class FloconNavigationState internal constructor() { | |||
There was a problem hiding this comment.
please :
- split into interface/impl
interface FloconNavigationState {
val stack: State<List<FloconRoute>>
fun navigate(route: FloconRoute)
fun back(count: Int = 1)
}
- use a mutable state & collect
// not sure mutableStateListOf exists, maybe mutableStateOf<List>(
class FloconNavigationState internal constructor() {
private val _stack = mutableStateListOf<FloconRoute>(LoadingRoute)
val stack: State<List<FloconRoute>> = _stack
fun navigate(route: FloconRoute) {
_stack.add(route)
}
fun back(count: Int = 1) {
repeat(count) { _stack.removeLast() }
}
}
val stack by navigationState.stack
doTTTTT
force-pushed
the
feature/nav3
branch
from
dcebe83 to
96b7cec
Compare
Open
added 14 commits
October 29, 2025 13:26
|
@florent37 I'll migrate progressively other screen to use nav3. Otherwise this PR will be to big |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.