Putu Tio Lovan | Register for OpenGuild FRAME Challenges #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Look great, can you create pow on Discord so we can give you your reward? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I replaced the existing todo()! in governance.rs and staking.rs with the appropriate code. In governance.rs I made changes to the create_proposal, vote and finalize_proposal functions based on the number of yes and no votes. The GovernancePallet structure can now better manage proposals through the HashMap, and ensure that proposals can only be finalised if they are still in Active status. Meanwhile in staking.rs, the functionality to manage staking and unstaking is now properly implemented using verified arithmetic operations. This mechanism ensures that users cannot stake more than they have available or unstake more than they have staked.