Skip to content

Conversation

@offamitkumar
Copy link
Member

@offamitkumar offamitkumar commented Nov 4, 2025

Trivial change,
After JDK-8288981 delivery test is now passing on s390x. So It can be removed from the problemlist.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8371188: [s390x] Un-ProblemList TestUnreachableInnerLoop.java (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28122/head:pull/28122
$ git checkout pull/28122

Update a local copy of the PR:
$ git checkout pull/28122
$ git pull https://git.openjdk.org/jdk.git pull/28122/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28122

View PR using the GUI difftool:
$ git pr show -t 28122

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28122.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 4, 2025

👋 Welcome back amitkumar! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 4, 2025

@offamitkumar This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8371188: [s390x] Un-ProblemList TestUnreachableInnerLoop.java

Reviewed-by: aph, phubner

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 25 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title 8371188 8371188: [s390x] Un-ProblemList TestUnreachableInnerLoop.java Nov 4, 2025
@openjdk
Copy link

openjdk bot commented Nov 4, 2025

@offamitkumar To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels
  • build
  • client
  • compiler
  • core-libs
  • graal
  • hotspot
  • hotspot-compiler
  • hotspot-gc
  • hotspot-jfr
  • hotspot-runtime
  • i18n
  • ide-support
  • javadoc
  • jdk
  • jmx
  • net
  • nio
  • security
  • serviceability
  • shenandoah

@offamitkumar offamitkumar marked this pull request as ready for review November 4, 2025 05:15
@offamitkumar
Copy link
Member Author

/label add hotspot

@openjdk openjdk bot added the hotspot hotspot-dev@openjdk.org label Nov 4, 2025
@openjdk
Copy link

openjdk bot commented Nov 4, 2025

@offamitkumar
The hotspot label was successfully added.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 4, 2025
@mlbridge
Copy link

mlbridge bot commented Nov 4, 2025

Webrevs

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 4, 2025
Copy link
Member

@Arraying Arraying left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot hotspot-dev@openjdk.org ready Pull request is ready to be integrated rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

3 participants