8366577: Deprecate java.net.Socket::setPerformancePreferences

[vy]

java.net.Socket::setPerformancePreferences was introduced in Java 1.5 with the intention of providing a declarative API for configuring the performance-wise characteristics of the underlying socket. It has always been a no-op and a corpus search does not reveal any significant usages of it. Recently merged JDK-8366575 removes the SDP (Sockets Direct Protocol) support, and this further undermines the value of setPerformancePreferences. This PR deprecates setPerformancePreferences and friends for removal.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Change requires CSR request JDK-8371210 to be approved
• Commit message must refer to an issue

Issues

• JDK-8366577: Deprecate java.net.Socket::setPerformancePreferences (Enhancement - P4)
• JDK-8371210: Deprecate java.net.Socket::setPerformancePreferences (CSR)

Reviewers

• Jaikiran Pai (@jaikiran - Reviewer) Review applies to 50826c3e
• Daniel Fuchs (@dfuch - Reviewer)
• Alan Bateman (@AlanBateman - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28129/head:pull/28129
$ git checkout pull/28129

Update a local copy of the PR:
$ git checkout pull/28129
$ git pull https://git.openjdk.org/jdk.git pull/28129/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28129

View PR using the GUI difftool:
$ git pr show -t 28129

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28129.diff

Using Webrev

Link to Webrev Comment

[vy]

/csr

[bridgekeeper]

👋 Welcome back vyazici! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@vy This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8366577: Deprecate java.net.Socket::setPerformancePreferences

Reviewed-by: dfuchs, alanb, jpai

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 61 new commits pushed to the master branch:

• c272aca: 8371091: Improve the exception message of NullPointerException thrown by the methods in the default implementation of HttpRequest.Builder
• 1f08a3e: 8355342: File.getCanonicalPath on Java 24 resolves paths on network drives to UNC format
• 1321186: 8367943: PipedOutputStream write(0, 0) successful after close()
• ... and 58 more: https://git.openjdk.org/jdk/compare/c1476fca9d7a679d32b7b43956638b845d1027cc...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@vy has indicated that a compatibility and specification (CSR) request is needed for this pull request.

@vy please create a CSR request for issue JDK-8366577 with the correct fix version. This pull request cannot be integrated until the CSR request is approved.

[openjdk]

@vy The following labels will be automatically applied to this pull request:

• net
• security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 02: Full - Incremental (c9384b09)
• 01: Full - Incremental (41c918cf)
• 00: Full (50826c3e)

[jaikiran]

This looks good to me.

[dfuch]

Looks good to me.

[vy]

@AlanBateman, @dfuch, @jaikiran, thanks so much for the reviews.

Tier 1-2 is clear on 50826c3 – succeeding commits were simple JavaDoc updates, hence not issuing another CI run.

/integrate

[openjdk]

Going to push as commit 866faa9.
Since your change was applied there have been 69 commits pushed to the master branch:

• e34a831: 8261743: Shenandoah: enable String deduplication with compact heuristics
• 8796611: 8272160: Avoid using 32-bit counters in CDS code
• 8a0c47d: 8371225: Missing release of GDK lock in Java_sun_awt_X11_GtkFileDialogPeer_run()
• ... and 66 more: https://git.openjdk.org/jdk/compare/c1476fca9d7a679d32b7b43956638b845d1027cc...master

Your commit was automatically rebased without conflicts.

[openjdk]

@vy Pushed as commit 866faa9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.