Skip to content

Conversation

@jsikstro
Copy link
Member

@jsikstro jsikstro commented Nov 5, 2025

Hello,

This RFE deprecates the AggressiveHeap flag in JDK 26. Please see the CSR for specific details on why this flag is being deprecated and workarounds for users interested in keeping similar behavior in the future.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change requires CSR request JDK-8370814 to be approved

Issues

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28144/head:pull/28144
$ git checkout pull/28144

Update a local copy of the PR:
$ git checkout pull/28144
$ git pull https://git.openjdk.org/jdk.git pull/28144/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28144

View PR using the GUI difftool:
$ git pr show -t 28144

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28144.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 5, 2025

👋 Welcome back jsikstro! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 5, 2025

@jsikstro This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8370813: Deprecate AggressiveHeap

Reviewed-by: ayang, shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 21 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added graal graal-dev@openjdk.org hotspot hotspot-dev@openjdk.org labels Nov 5, 2025
@openjdk
Copy link

openjdk bot commented Nov 5, 2025

@jsikstro The following labels will be automatically applied to this pull request:

  • graal
  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 5, 2025
@jsikstro
Copy link
Member Author

jsikstro commented Nov 5, 2025

/label remove graal

@openjdk openjdk bot removed the graal graal-dev@openjdk.org label Nov 5, 2025
@openjdk
Copy link

openjdk bot commented Nov 5, 2025

@jsikstro
The graal label was successfully removed.

@mlbridge
Copy link

mlbridge bot commented Nov 5, 2025

Webrevs

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 5, 2025
@jsikstro
Copy link
Member Author

Thank you for the reviews! @albertnetymk @shipilev
/integrate

@openjdk
Copy link

openjdk bot commented Nov 10, 2025

Going to push as commit 2c378e2.
Since your change was applied there have been 65 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 10, 2025
@openjdk openjdk bot closed this Nov 10, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 10, 2025
@openjdk
Copy link

openjdk bot commented Nov 10, 2025

@jsikstro Pushed as commit 2c378e2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot hotspot-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

3 participants