Skip to content

Conversation

@PeyaPeyaPeyang
Copy link
Contributor

@PeyaPeyaPeyang PeyaPeyaPeyang commented Nov 5, 2025

Fix JavaDoc typos in Cipher class: correct {code ...} to {@code ...} in the constructor and getMaxAllowedParameterSpec()


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8357880: Code formatting typo in Cipher.getMaxAllowedParameterSpec (Bug - P5)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28145/head:pull/28145
$ git checkout pull/28145

Update a local copy of the PR:
$ git checkout pull/28145
$ git pull https://git.openjdk.org/jdk.git pull/28145/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28145

View PR using the GUI difftool:
$ git pr show -t 28145

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28145.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 5, 2025

👋 Welcome back PeyaPeyaPeyang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 5, 2025

@PeyaPeyaPeyang This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8357880: Code formatting typo in Cipher.getMaxAllowedParameterSpec

Reviewed-by: fandreuzzi, mullan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 8 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@seanjmullan) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the security security-dev@openjdk.org label Nov 5, 2025
@openjdk
Copy link

openjdk bot commented Nov 5, 2025

@PeyaPeyaPeyang The following label will be automatically applied to this pull request:

  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 5, 2025
@mlbridge
Copy link

mlbridge bot commented Nov 5, 2025

Webrevs

@openjdk
Copy link

openjdk bot commented Nov 5, 2025

⚠️ @PeyaPeyaPeyang the full name on your profile does not match the author name in this pull requests' HEAD commit. If this pull request gets integrated then the author name from this pull requests' HEAD commit will be used for the resulting commit. If you wish to push a new commit with a different author name, then please run the following commands in a local repository of your personal fork:

$ git checkout 8357880-fix-typo-in-javadoc
$ git commit --author='Preferred Full Name <you@example.com>' --allow-empty -m 'Update full name'
$ git push

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 5, 2025
@PeyaPeyaPeyang
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Nov 5, 2025
@openjdk
Copy link

openjdk bot commented Nov 5, 2025

@PeyaPeyaPeyang
Your change (at version 408ea85) is now ready to be sponsored by a Committer.

@wangweij
Copy link
Contributor

wangweij commented Nov 5, 2025

/sponsor

@openjdk
Copy link

openjdk bot commented Nov 5, 2025

Going to push as commit d5831ed.
Since your change was applied there have been 13 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 5, 2025
@openjdk openjdk bot closed this Nov 5, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Nov 5, 2025
@openjdk
Copy link

openjdk bot commented Nov 5, 2025

@wangweij @PeyaPeyaPeyang Pushed as commit d5831ed.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integrated Pull request has been integrated security security-dev@openjdk.org

Development

Successfully merging this pull request may close these issues.

4 participants