8371316: Adjust assertion (GC pause time cannot be smaller than the sum of each phase) in G1GCPhaseTimes::print

[MBaesken]

it has been observed that the assertion (GC pause time cannot be smaller than the sum of each phase) in G1GCPhaseTimes::print cuts off the printed values, this should be adjusted to see the real values in error situations.
The current assert prints misleading messages like this (see JDK-8370063) :

# Internal Error (d:\priv\jenkins\ci2\client-home\workspace\openjdk-jdk-windows_x86_64-dbg\jdk\src\hotspot\share\gc\g1\g1GCPhaseTimes.cpp:571), pid=8976, tid=24744
# assert(_gc_pause_time_ms >= accounted_ms) failed: GC pause time(0.001ms) cannot be smaller than the sum of each phase(0.001ms).

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8371316: Adjust assertion (GC pause time cannot be smaller than the sum of each phase) in G1GCPhaseTimes::print (Enhancement - P4)

Reviewers

• Albert Mingkun Yang (@albertnetymk - Reviewer)
• Thomas Schatzl (@tschatzl - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28147/head:pull/28147
$ git checkout pull/28147

Update a local copy of the PR:
$ git checkout pull/28147
$ git pull https://git.openjdk.org/jdk.git pull/28147/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28147

View PR using the GUI difftool:
$ git pr show -t 28147

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28147.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@MBaesken This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8371316: Adjust assertion (GC pause time cannot be smaller than the sum of each phase) in G1GCPhaseTimes::print

Reviewed-by: ayang, tschatzl

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 8 new commits pushed to the master branch:

• b0536f9: 8370201: Test serviceability/sa/TestJhsdbJstackWithVirtualThread.java fails due to VM warnings
• 973dc3f: 8371009: HttpClient javadoc synchronous example missing HttpRequest variable declaration
• 2dd15cf: 8346719: Add relaunchers to the static JDK image for missing executables
• ... and 5 more: https://git.openjdk.org/jdk/compare/f5d8bd0dd50bcd963b4062997aecb4e15249e30d...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@MBaesken The following label will be automatically applied to this pull request:

• hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (f374c8ab)

[MBaesken]

Thanks for the reviews !

/integrate

[openjdk]

Going to push as commit db76479.
Since your change was applied there have been 19 commits pushed to the master branch:

• ac9cf5d: 8370878: C1: Clean up unnecessary ConversionStub constructor
• c754e3e: 8368528: HttpClient.Builder.connectTimeout should accept arbitrarily large values
• 3f40f4c: 8370975: OutputAnalyzer.matches() should use Matcher with Pattern.MULTILINE
• ... and 16 more: https://git.openjdk.org/jdk/compare/f5d8bd0dd50bcd963b4062997aecb4e15249e30d...master

Your commit was automatically rebased without conflicts.

[openjdk]

@MBaesken Pushed as commit db76479.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.