8361487: [ubsan] test_committed_virtualmemory.cpp check_covered_pages shows overflow #28151
+3
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the test, page-numbers to be checked are passed to a checker function in which they will be changed to
-1if they are as expected.Use of these
-1values for page-numbers in consequent checks result in overflow in pointer arithmetic ofbase + (-1) * page_sizewhich is certainly less thanbase.The fix is to skip cases where page-number under checking is
-1.Tested under UBSAN build.
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28151/head:pull/28151$ git checkout pull/28151Update a local copy of the PR:
$ git checkout pull/28151$ git pull https://git.openjdk.org/jdk.git pull/28151/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 28151View PR using the GUI difftool:
$ git pr show -t 28151Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28151.diff
Using Webrev
Link to Webrev Comment