Skip to content

Conversation

@GoeLin
Copy link
Member

@GoeLin GoeLin commented Dec 9, 2025

I backport this for parity with 21.0.11-oracle.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8345668 needs maintainer approval

Issue

  • JDK-8345668: ZoneOffset.ofTotalSeconds performance regression (Bug - P3 - Requested)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/2510/head:pull/2510
$ git checkout pull/2510

Update a local copy of the PR:
$ git checkout pull/2510
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/2510/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2510

View PR using the GUI difftool:
$ git pr show -t 2510

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/2510.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 9, 2025

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 9, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 9a60f4457bb56d0f5039a97e6b943e62a8a2c3ee 8345668: ZoneOffset.ofTotalSeconds performance regression Dec 9, 2025
@openjdk
Copy link

openjdk bot commented Dec 9, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Dec 9, 2025
@openjdk
Copy link

openjdk bot commented Dec 9, 2025

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 9, 2025
@mlbridge
Copy link

mlbridge bot commented Dec 9, 2025

Webrevs

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Dec 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approval Requires approval; will be removed when approval is received backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant