-
Notifications
You must be signed in to change notification settings - Fork 16
8364248: Separate commit and reservation limit detection #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
8364248: Separate commit and reservation limit detection #11
Conversation
|
👋 Welcome back shade! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
|
This backport pull request has now been updated with issue from the original commit. |
|
|
|
/approval request Cleanups the OS/GC interface a bit, and makes further backports in container code cleaner. Notably, it is on the way to JDK-8370572 backport. Applies cleanly. hotspot_gc tests pass. Risk is on lower side: this is mostly a refactoring, and has no bugtail since initial integration 4 months ago. |
This cleanup makes further backports in container code cleaner. Notably, it is on the way to JDK-8370572 backport. The full stack looks like this:
Additional testing:
hotspot_gcProgress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u-dev.git pull/11/head:pull/11$ git checkout pull/11Update a local copy of the PR:
$ git checkout pull/11$ git pull https://git.openjdk.org/jdk25u-dev.git pull/11/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 11View PR using the GUI difftool:
$ git pr show -t 11Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk25u-dev/pull/11.diff
Using Webrev
Link to Webrev Comment