Skip to content

Conversation

@shipilev
Copy link
Member

@shipilev shipilev commented Nov 26, 2025

This cleanup makes further backports in container code cleaner. Notably, it is on the way to JDK-8370572 backport. The full stack looks like this:

    Clean JDK-8370966: Create regression test for the hierarchical memory limit fix in JDK-8370572
(!) Clean JDK-8370572: Cgroups hierarchical memory limit is not honored after JDK-8322420
    Clean JDK-8292984: Refactor internal container-related interfaces for clarity
    Clean JDK-8356868: Not all cgroup parameters are made available
    Clean JDK-8367485: os::physical_memory is broken in 32-bit JVMs when running on 64-bit OSes
    Clean JDK-8357086: os::xxx functions returning memory size should return size_t
    Clean JDK-8357570: [macOS] os::Bsd::available_memory() might return too low values
>>> Clean JDK-8364248: Separate commit and reservation limit detection

Additional testing:

  • Linux x86_64 server fastdebug, hotspot_gc

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8364248 needs maintainer approval

Issue

  • JDK-8364248: Separate commit and reservation limit detection (Enhancement - P4 - Requested)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u-dev.git pull/11/head:pull/11
$ git checkout pull/11

Update a local copy of the PR:
$ git checkout pull/11
$ git pull https://git.openjdk.org/jdk25u-dev.git pull/11/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11

View PR using the GUI difftool:
$ git pr show -t 11

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk25u-dev/pull/11.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 26, 2025

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 26, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport ae11d8f44689502d35cb511e9ce288ab7cc0acae 8364248: Separate commit and reservation limit detection Nov 26, 2025
@openjdk
Copy link

openjdk bot commented Nov 26, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Nov 26, 2025
@openjdk
Copy link

openjdk bot commented Nov 26, 2025

⚠️ @shipilev This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 26, 2025
@mlbridge
Copy link

mlbridge bot commented Nov 26, 2025

Webrevs

@shipilev
Copy link
Member Author

/approval request Cleanups the OS/GC interface a bit, and makes further backports in container code cleaner. Notably, it is on the way to JDK-8370572 backport. Applies cleanly. hotspot_gc tests pass. Risk is on lower side: this is mostly a refactoring, and has no bugtail since initial integration 4 months ago.

@openjdk
Copy link

openjdk bot commented Nov 28, 2025

@shipilev
8364248: The approval request has been created successfully.

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Nov 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approval Requires approval; will be removed when approval is received backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant