8358735: GenShen: block_start() may be incorrect after class unloading #19
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of JDK-8358735 and its two follow up fixes: JDK-8372110 and JDK-8371854.
The backport of the original issue (JDK-8358735) is almost clean except that atomic.hpp was renamed to atomicAccess.hpp in the later versions, and I had to resolve the conflict by retaining atomic.hpp import.
The two follow up backports are clean.
Our internal application crashed and we identified JDK-8358735 was the root cause. Backporting it for the fix.
Testing: all GHA tests passed.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u-dev.git pull/19/head:pull/19$ git checkout pull/19Update a local copy of the PR:
$ git checkout pull/19$ git pull https://git.openjdk.org/jdk25u-dev.git pull/19/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 19View PR using the GUI difftool:
$ git pr show -t 19Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk25u-dev/pull/19.diff
Using Webrev
Link to Webrev Comment