Skip to content

Conversation

@rgithubli
Copy link

@rgithubli rgithubli commented Nov 26, 2025

Backport of JDK-8358735 and its two follow up fixes: JDK-8372110 and JDK-8371854.

The backport of the original issue (JDK-8358735) is almost clean except that atomic.hpp was renamed to atomicAccess.hpp in the later versions, and I had to resolve the conflict by retaining atomic.hpp import.

The two follow up backports are clean.

Our internal application crashed and we identified JDK-8358735 was the root cause. Backporting it for the fix.

Testing: all GHA tests passed.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8358735 needs maintainer approval

Issue

  • JDK-8358735: GenShen: block_start() may be incorrect after class unloading (Bug - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u-dev.git pull/19/head:pull/19
$ git checkout pull/19

Update a local copy of the PR:
$ git checkout pull/19
$ git pull https://git.openjdk.org/jdk25u-dev.git pull/19/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 19

View PR using the GUI difftool:
$ git pr show -t 19

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk25u-dev/pull/19.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 26, 2025

👋 Welcome back rgithubli! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 26, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 8531fa146be1da5e96c0f23091882a27c67d7893 8358735: GenShen: block_start() may be incorrect after class unloading Nov 26, 2025
@openjdk
Copy link

openjdk bot commented Nov 26, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Nov 26, 2025
@openjdk
Copy link

openjdk bot commented Nov 26, 2025

⚠️ @rgithubli This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 26, 2025
@mlbridge
Copy link

mlbridge bot commented Nov 26, 2025

Webrevs

Backport aa7718d1d2008c240c197383c493955d8b654bf3
Backport 713de231a61234632e2f9858b222b5f7fd0bdaf1
@openjdk openjdk bot removed the clean Identical backport; no merge resolution required label Nov 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

2 participants