Skip to content

Conversation

@shipilev
Copy link
Member

@shipilev shipilev commented Nov 27, 2025

Backporting to fix the regression in JDK 25 feature, and to match 25.0.3-oracle.

Additional testing:

  • macos-aarch64-server-fastdebug, new regression test fails without the test, passes with it

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8370887 needs maintainer approval

Issue

  • JDK-8370887: DelayScheduler.replace method may break the 4-ary heap in certain scenarios (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u-dev.git pull/27/head:pull/27
$ git checkout pull/27

Update a local copy of the PR:
$ git checkout pull/27
$ git pull https://git.openjdk.org/jdk25u-dev.git pull/27/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 27

View PR using the GUI difftool:
$ git pr show -t 27

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk25u-dev/pull/27.diff

Using Webrev

Link to Webrev Comment

@shipilev
Copy link
Member Author

@GoeLin, I am going to re-use the existing approval from openjdk/jdk25u#394, if that's fine with you.

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 27, 2025

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 27, 2025

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8370887: DelayScheduler.replace method may break the 4-ary heap in certain scenarios

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 8 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport cc5b35bf69dcf9e7e8037642c94e8d7e5847952d 8370887: DelayScheduler.replace method may break the 4-ary heap in certain scenarios Nov 27, 2025
@openjdk
Copy link

openjdk bot commented Nov 27, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 27, 2025
@mlbridge
Copy link

mlbridge bot commented Nov 27, 2025

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required ready Pull request is ready to be integrated rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant