Skip to content

ext-link in refs outputting twice #4918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

ext-link in refs outputting twice #4918

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/transform/xsl/default.xsl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1860,7 +1860,7 @@
<xsl:template match="mixed-citation">
<!-- Render each mixed-citation as-is https://jats.nlm.nih.gov/archiving/tag-library/1.1/element/mixed-citation.html -->
<!-- Only exceptions are that we want titles <source> in italics and hyperlinked uris elements-->
<xsl:apply-templates select="source | node()" mode="nscitation"/>
<xsl:apply-templates select="source | node()[not(self::ext-link)]" mode="nscitation"/>
<xsl:apply-templates select="ext-link"/>
Comment on lines +1863 to 1864
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the correct solution here is to remove the redundancy on line 1864. The nscitation template for ext-link adds additional behaviour I think we want to preserve

</xsl:template>

Expand Down