a11y updates to full-text-search pages #4964
Conversation
A11y Syntax NotesOLH theme has space around sections, so when they are put in to make landmarks, this can cause layout shifts. So now we have a class for when these are being used 'invisibly' to provide landmarks. section.invisible-landmark{
padding: 0;
margin: 0;
}Currently this is only a concern on OLH, as the other two themese don't ahve spacing, however it may be useful to extend this to all three themes and markup any sections that are purely to provide aria landmarks with this class. |
There was a problem hiding this comment.
Looks good. Found a few small bugs, and also added a few comments about readability around keeping this code distinct from the templates and patterns that belong to GenericFacetedListView, which granted are not very well documented as belonging specifically to it!
joemull
assigned
StephDriver and
mauromsl and unassigned
joemull,
StephDriver and
mauromsl
|
|
||
| paginate_by = request.GET.get("paginate_by", 25) | ||
| if paginate_by == "all": | ||
| paginate_by = len(articles) if articles else 25 |
There was a problem hiding this comment.
In terms of implementation, qs.count() is always preferred for querysets over len(qs)
I wonder, however, if we really want to support "all" as a feature, since we do not have a dynamic loader for this, we could put a lot of strain on the server. I don't think the user will be happy waiting for potentially thousands of results to be returned and displayed all at once
3 participants
closes #4839