-
Notifications
You must be signed in to change notification settings - Fork 82
Introduces changes for clarity against clean for sanity checks. #4989
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Article Page ObservationsScreenshots are Clean first, Clarity second. Text optionsThey've moved from right to left, and removal of boxes. I think they should have button styling, rather than be floating text. ![]() ![]() LInk Icon StylesThey've changed from being styled to receed and be different to surrounding text, to having the same style. Those which were supescript have also become aligned with text. I think they should be different - making them recede slighting makes them easy to skip passed with the eye, rather than having to process - and they are designed for exactly that, not to interrupt the user and force them to pay attention, but to be there if information is needed. ![]() ![]() ![]() Side Pane Width / ShareAs text is larger, the sidepane now fits less - this isn't a zoom issue, this is about the relative sizes. So this means that the share article and its copy button now flow cross two lines. As the share box doesn't include all teh text anyway, I think this should be reduced in size (or the button should be smaller) so that they fit again on a single line, relative to the size of the side pane. However it may also be good to review the size of the pane itself, as other contents likewise may now reflow across multiple lines. Something odd is happening with the height of the copy button too. ![]() ![]() Citation Buttons Focus Visible delayFor the citaiton buttons, the focus visible fades in slowly (compared to when tabbing onto other elements) - this means it takes a while when tabbing in to realise where hte focus is. This doesn't happen on clean, or with other buttons on this page. To repeat, tab with keyboard down teh side bar, notice how each element gains the focus ring instantly, then tab into the Citation section and see the difference. Notes back to text iconedit. Fixed in #4446 |
Following discussion of the above:
Discussion: Colour PairsWe have moved to using colour pairs in our CSS to make it easier to ensure good contrast. The CSS for clarity hasn't been arranged in taht way, with it unclear which colours may be used on which backgrounds. |
making further a11y tweaks in #5007 |
This doesn't close any issues on its own and will be closed without being merged. This issue has been opened soley for the purpose of checking it does not eliminate the changes that have been made for a11y so far.
This theme includes three palettes:
These can be changed by switching the import in clean.css.
Plan
A rough plan has formed around this PR. If we find that we like it we have two options:
Personally I think option 1 that gives us time to shift people over. Increases some maintenance in the short term. But we could make clarity a sub theme and eliminate templates that are identical to clean.