fix(build): remove unwanted referenceapplication-demo folder from distribution #941
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tro output - Adds Maven Antrun plugin step to delete the redundant referenceapplication-demo folder after SDK build - Ensures demo content is preserved via referencedemodata module - Maintains integrity of build and application functionality - Implements safe, robust, and maintainable solution as per verification and best practices
|
@UjjawalPrabhat what are the exact steps to reproduce the unwanted demo folder? |
Thanks for reviewing! Here’s how to reproduce the unwanted referenceapplication-demo folder:
You will see both: The referenceapplication-demo folder is the unwanted directory. Let me know if you need any more details! |
|
Are you able to reproduce it with the 3.6.0-SNAPSHOT? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Removes the redundant
referenceapplication-demodirectory from the OpenMRS distribution build by introducing a Maven Antrun plugin execution post-SDK build. This ensures the demo folder does not appear in the final artifacts, maintaining a clean and correct output.Details
distro/pom.xmlto safely delete thereferenceapplication-demofolder after the build-distro phase.Linked Resource
Checklist