-
Notifications
You must be signed in to change notification settings - Fork 105
added ConfigurationPropertiesDefaultValueTest for LST contains invalid nodes #713
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
tubbynl
wants to merge
8
commits into
openrewrite:main
Choose a base branch
from
tubbynl:bugfix/lst-contains-erroneous-nodes
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
8941f6d
added ConfigurationPropertiesDefaultValueTest for LST contains invali…
tubbynl ef860c3
Merge branch 'main' into bugfix/lst-contains-erroneous-nodes
timtebeek 53751a2
Apply suggestions from code review
timtebeek b2414c9
Merge branch 'main' into bugfix/lst-contains-erroneous-nodes
timtebeek 7992b74
Merge branch 'main' into bugfix/lst-contains-erroneous-nodes
Laurens-W 1b940fd
Fix compile issue
Laurens-W 6ba959a
Merge branch 'main' into bugfix/lst-contains-erroneous-nodes
jevanlingen d861cee
Update ConfigurationPropertiesDefaultValueTest.java
timtebeek File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
64 changes: 64 additions & 0 deletions
64
...t_3_4/java/org/openrewrite/java/spring/boot3/ConfigurationPropertiesDefaultValueTest.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,64 @@ | ||
/* | ||
* Copyright 2024 the original author or authors. | ||
* <p> | ||
* Licensed under the Moderne Source Available License (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* <p> | ||
* https://docs.moderne.io/licensing/moderne-source-available-license | ||
* <p> | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
package org.openrewrite.java.spring.boot3; | ||
|
||
import org.junit.jupiter.api.Test; | ||
import org.openrewrite.DocumentExample; | ||
import org.openrewrite.java.JavaParser; | ||
import org.openrewrite.test.RecipeSpec; | ||
import org.openrewrite.test.RewriteTest; | ||
|
||
import static org.openrewrite.java.Assertions.java; | ||
|
||
class ConfigurationPropertiesDefaultValueTest implements RewriteTest { | ||
|
||
@Override | ||
public void defaults(RecipeSpec spec) { | ||
spec.parser(JavaParser.fromJavaVersion() | ||
.classpath("spring-boot") | ||
); | ||
} | ||
|
||
@DocumentExample | ||
@Test | ||
timtebeek marked this conversation as resolved.
Show resolved
Hide resolved
|
||
void lstContainsErroneousNodes() { | ||
rewriteRun( | ||
//language=java | ||
java( | ||
""" | ||
import org.springframework.boot.context.properties.ConfigurationProperties; | ||
import org.springframework.boot.context.properties.bind.DefaultValue; | ||
|
||
@ConfigurationProperties("nl.tubby") | ||
record TestTubbyProperties( | ||
@DefaultValue("https://www.tubby.nl") String url | ||
) { | ||
} | ||
""", | ||
""" | ||
import org.springframework.boot.context.properties.ConfigurationProperties; | ||
import org.springframework.boot.context.properties.bind.DefaultValue; | ||
|
||
@ConfigurationProperties("nl.tubby") | ||
record TestTubbyProperties( | ||
@DefaultValue("https://www.tubby.nl") String url | ||
) { | ||
timtebeek marked this conversation as resolved.
Show resolved
Hide resolved
|
||
} | ||
""" | ||
) | ||
); | ||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.