Skip to content

Conversation

jetbrains-junie[bot]
Copy link
Contributor

📌 Hey! This PR was made for you with Junie, the coding agent by JetBrains Early Access Preview

It's still learning, developing, and might make mistakes. Please make sure you review the changes before you accept them.
We’d love your feedback — join our Discord to share bugs, ideas: here.

📊 Junie Summary

A new recipe was implemented to convert Spring field injection to constructor injection, handling @Autowired and @Qualifier annotations. The tests initially failed due to formatting issues and handling of existing constructors, but modifications were made to address these problems. The updated recipe is now being tested in hopes of achieving the desired functionality correctly.

 A new recipe was implemented to convert Spring field injection to constructor injection, handling `@Autowired` and `@Qualifier` annotations. The tests initially failed due to formatting issues and handling of existing constructors, but modifications were made to address these problems. The updated recipe is now being tested in hopes of achieving the desired functionality correctly.
@jetbrains-junie jetbrains-junie bot added the junie label Jun 4, 2025
@github-project-automation github-project-automation bot moved this to In Progress in OpenRewrite Jun 4, 2025
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions could not be made:

  • build.gradle.kts
    • lines 147-146

@knutwannheden
Copy link
Contributor

@jetbrains-junie Note that most of the new tests are failing. For types referenced from Java source files in tests (using Assertions.java()) it is correct to configure the classpath dependencies via JavaParser.Builder. But instead of using the classpath() method the dependencies should be configured using classpathFromResources() which indirectly loads the dependencies from the recioeDependencies configuration in the Gradle build script. Please see other tests for how that is done and note that the configuration often includes multiple versions of a given Maven artifact and thus often needs the dependency to be specified in a way that uniquely prefix-matches the artifact file name as in "spring-beans-5" for example.

Copy link
Contributor Author

Hey, it’s Junie by JetBrains! I started processing your request 🚀

A pull request updated classpath dependencies to `classpathFromResources()` for tests converting Spring field injection to constructor injection. Despite these changes, seven tests failed due to formatting discrepancies and issues with annotation recognition. Further adjustments are needed to resolve these failures.
Copy link
Contributor Author

A pull request updated classpath dependencies to classpathFromResources() for tests converting Spring field injection to constructor injection. Despite these changes, seven tests failed due to formatting discrepancies and issues with annotation recognition. Further adjustments are needed to resolve these failures.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions could not be made:

  • build.gradle.kts
    • lines 147-146

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@timtebeek timtebeek marked this pull request as draft June 15, 2025 20:15
@timtebeek
Copy link
Member

@knutwannheden What would we want to do with this PR? There's parallel classes doing the same thing. Should we consolidate and attempt to get this merged? Or just abandon and try again with Claude?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

2 participants