MissingOverrideAnnotation: removeFalsyOverrideAnnotation #684
Conversation
|
is this any good? @timtebeek fell free to tune and complete @iddeepak |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| import lombok.var; | ||
| import org.jspecify.annotations.Nullable; |
There was a problem hiding this comment.
| import lombok.var; | |
| import org.jspecify.annotations.Nullable; | |
| import org.jspecify.annotations.Nullable; |
| public void doesNotOverrideAnything() { | ||
| } | ||
| } | ||
| """) |
There was a problem hiding this comment.
| """) | |
| """ | |
| ) |
| public void method2() { | ||
| } | ||
| } | ||
| """) |
There was a problem hiding this comment.
| """) | |
| """ | |
| ) |
| \s | ||
| public void invalidMethod() {} | ||
| } | ||
| """) |
There was a problem hiding this comment.
| """) | |
| """ | |
| ) |
| """) | ||
| ); |
There was a problem hiding this comment.
| """) | |
| ); | |
| """ | |
| ) | |
| @Test |
| public void documentedMethod() { | ||
| } | ||
| } | ||
| """) |
There was a problem hiding this comment.
| """) | |
| """ | |
| ) |
| public void annotatedMethod() { | ||
| } | ||
| } | ||
| """) |
There was a problem hiding this comment.
| """) | |
| """ | |
| ) |
Pankraz76
changed the title
Pankraz76
changed the title
|
On my machine this already fails to compile; what would be the reason then to add this to a recipe that aims to add missing override annotations? I'd lean towards closing this effort, as it's quite unlikely, and misplaced / unexpected in this recipe. |
What about changing the scope to check for corrupt (missing/falsy) override annotations. We could create a new one like As if not, gonna have to copy potentially every recipe 1 times to check for false negative as well. |
|
As indicated above, a misplaced Override annotation already does not compile on my machine; have you seen any number of example of that in the wild at all that warrant an automated remediation? If there's a convincing case we can reopen, but for now I just don't see it. |
|
this was my intention: |
What's changed?
It seems the rules does not cover false positives as well. Should this be included?
What's your motivation?
are those annotations really necessary
Anything in particular you'd like reviewers to focus on?
Anyone you would like to review specifically?
Have you considered any alternatives or workarounds?
Any additional context
Checklist