Skip to content

Conversation

aThorp96
Copy link
Member

@aThorp96 aThorp96 commented Oct 3, 2025

πŸ“ Description of the Change

Add a more general "controlling comment volume" section with Github and Gitlab subsections to clarify the shared semantics

πŸ‘¨πŸ»β€ Linked Jira

None

πŸ”— Linked GitHub Issue

Fixes #2270

πŸš€ Type of Change

  • πŸ› Bug fix (fix:)
  • ✨ New feature (feat:)
  • πŸ’₯ Breaking change (feat!:, fix!:)
  • πŸ“š Documentation update (docs:)
  • βš™οΈ Chore (chore:)
  • πŸ’… Refactor (refactor:)
  • πŸ”§ Enhancement (enhance:)
  • πŸ“¦ Dependency update (deps:)

πŸ§ͺ Testing Strategy

  • Unit tests
  • Integration tests
  • End-to-end tests
  • Manual testing
  • Not Applicable

πŸ€– AI Assistance

  • I have not used any AI assistance for this PR.
  • I have used AI assistance for this PR.

If you have used AI assistance, please provide the following details:

Which LLM was used?

  • GitHub Copilot
  • ChatGPT (OpenAI)
  • Claude (Anthropic)
  • Cursor
  • Gemini (Google)
  • Other: ____________

Extent of AI Assistance:

  • Documentation and research only
  • Unit tests or E2E tests only
  • Code generation (parts of the code)
  • Full code generation (most of the PR)
  • PR description and comments
  • Commit message(s)

Important

If the majority of the code in this PR was generated by an AI, please add a Co-authored-by trailer to your commit message.
For example:

Co-authored-by: Gemini gemini@google.com
Co-authored-by: ChatGPT noreply@chatgpt.com
Co-authored-by: Claude noreply@anthropic.com
Co-authored-by: Cursor noreply@cursor.com
Co-authored-by: Copilot Copilot@users.noreply.github.com

**πŸ’‘You can use the script ./hack/add-llm-coauthor.sh to automatically add
these co-author trailers to your commits.

βœ… Submitter Checklist

  • πŸ“ My commit messages are clear, informative, and follow the project's How to write a git commit message guide. The Gitlint linter ensures in CI it's properly validated
  • ✨ I have ensured my commit message prefix (e.g., fix:, feat:) matches the "Type of Change" I selected above.
  • β™½ I have run make test and make lint locally to check for and fix any
    issues. For an efficient workflow, I have considered installing
    pre-commit and running pre-commit install to
    automate these checks.
  • πŸ“– I have added or updated documentation for any user-facing changes.
  • πŸ§ͺ I have added sufficient unit tests for my code changes.
  • 🎁 I have added end-to-end tests where feasible. See README for more details.
  • πŸ”Ž I have addressed any CI test flakiness or provided a clear reason to bypass it.
  • If adding a provider feature, I have filled in the following and updated the provider documentation:
    • GitHub App
    • GitHub Webhook
    • Gitea/Forgejo
    • GitLab
    • Bitbucket Cloud
    • Bitbucket Data Center

Closes #2278

@pipelines-as-code pipelines-as-code bot added documentation Improvements or additions to documentation github gitlab repo-cr labels Oct 3, 2025
@aThorp96 aThorp96 force-pushed the comment-strategy-docs branch from 8e90501 to aa91dd0 Compare October 3, 2025 17:16
Copy link

pipelines-as-code bot commented Oct 3, 2025

πŸ” PR Lint Feedback

Note: This automated check helps ensure your PR follows our contribution guidelines.

⚠️ Items that need attention:

πŸ€– AI attribution

The following commits lack an explicit AI attribution footer:

  • 3fbfaad docs: Clarify documentation for repository comment_strategy``

If no AI assistance was used for a commit, you can ignore this warning.
Otherwise add an Assisted-by: or Co-authored-by: footer referencing the AI used.


ℹ️ Next Steps

  • Review and address the items above
  • Push new commits to update this PR
  • This comment will be automatically updated when issues are resolved
πŸ”§ Admin Tools (click to expand)

Automated Issue/Ticket Creation:

  • /issue-create - Generate a GitHub issue from this PR content using AI
  • /jira-create - Create a SRVKP Jira ticket from this PR content using AI

⚠️ Important: Always review and edit generated content before finalizing tickets/issues.
The AI-generated content should be used as a starting point and may need adjustments.

These commands are available to maintainers and will post the generated content as PR comments for review.

πŸ€– This feedback was generated automatically by the PR CI system

@aThorp96 aThorp96 force-pushed the comment-strategy-docs branch 2 times, most recently from 37cfcaa to e610be4 Compare October 3, 2025 17:32
@aThorp96 aThorp96 requested review from chmouel and zakisk October 3, 2025 17:46
@chmouel
Copy link
Member

chmouel commented Oct 6, 2025

/gemini review

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request does a great job of refactoring the documentation for the comment_strategy setting. Consolidating the information for GitHub and GitLab into a shared section significantly improves clarity and reduces duplication. I have a couple of minor suggestions to enhance the grammar and maintain consistency with the rest of the document.

@chmouel
Copy link
Member

chmouel commented Oct 6, 2025

See the minor spell if you want to fix and it's GTG for me

@chmouel
Copy link
Member

chmouel commented Oct 7, 2025

/issue-create

Copy link

βœ… GitHub Issue Created

AI-generated issue has been created and linked to this PR

πŸ“‹ Created Issue

#2278 - Feature Request: Clarify documentation on controlling comment volume for Git providers

πŸ”— Relationship

This pull request resolves the issue described above. The issue was automatically generated based on the PR content to represent the underlying problem being solved.

πŸ“ Issue Content Preview

Click to view the generated issue content

Problem Description

Users need a clearer understanding of how to manage and control the volume of automated comments generated by the system across different Git providers like GitHub and GitLab.

Current Behavior

The existing documentation on repository settings, specifically comment_strategy, may be difficult to interpret or lacks sufficient detail to fully grasp the shared semantics and practical implications for controlling comment volume across various Git platforms.

Expected Behavior

The documentation should provide a comprehensive and easy-to-understand explanation of how to configure and manage the comment_strategy setting to effectively control the amount of automated commenting on repositories, with clear guidance tailored for both GitHub and GitLab environments.

Additional Context

This clarity is important for users who want to fine-tune the system's interaction with their repositories, preventing excessive or unwanted comments and ensuring a more streamlined workflow.


πŸ€– Issue created automatically using /issue-create command

Add a more general "controlling comment volume" section with Github
and Gitlab subsections to clarify the shared semantics
@aThorp96 aThorp96 force-pushed the comment-strategy-docs branch from e610be4 to 3fbfaad Compare October 7, 2025 16:12
@pipelines-as-code pipelines-as-code bot added the doc label Oct 7, 2025
@chmouel
Copy link
Member

chmouel commented Oct 7, 2025

i think it may be better to just set things as ready for review, I don't think it's necessary to do a draft pr or this would be confusing when to merge

@aThorp96 aThorp96 marked this pull request as ready for review October 7, 2025 19:35
@aThorp96
Copy link
Member Author

aThorp96 commented Oct 7, 2025

AH, didn't realize I created this as a draft. Must have been a cached setting πŸ€” Marked as ready for review πŸ™‡πŸΌ

@chmouel chmouel merged commit 4ca0628 into openshift-pipelines:main Oct 8, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc documentation Improvements or additions to documentation gitlab
Development

Successfully merging this pull request may close these issues.

Feature Request: Clarify documentation on controlling comment volume for Git providers docs: GitLab comment strategy missing validation failure note
2 participants