-
Notifications
You must be signed in to change notification settings - Fork 27
OCPBUGS-63538: Create a PreprovisioningImage for servicing if needed #435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release-4.20
Are you sure you want to change the base?
Conversation
The current code ignores PreprovisioningImages for provisioned nodes. While normally there is a leftover PreprovisioningImage from the deployment, it's not the case for externally provisioned hosts. Signed-off-by: Dmitry Tantsur <dtantsur@protonmail.com> (cherry picked from commit c8e8ee1)
|
@dtantsur: This pull request references Jira Issue OCPBUGS-63538, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dtantsur The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/jira refresh |
|
@dtantsur: This pull request references Jira Issue OCPBUGS-63538, which is valid. The bug has been moved to the POST state. 7 validation(s) were run on this bug
Requesting review from QA contact: DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/retest timeout |
|
/label backport-risk-assessed |
|
/retest |
|
/test e2e-metal-ipi-virtualmedia |
|
@dtantsur: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/lgtm |
The current code ignores PreprovisioningImages for provisioned nodes.
While normally there is a leftover PreprovisioningImage from the
deployment, it's not the case for externally provisioned hosts.
Signed-off-by: Dmitry Tantsur dtantsur@protonmail.com
(cherry picked from commit c8e8ee1)