OCPBUGS-70265: Fix errors.As usage for NoDataInSecretError

[elfosardo]

The errors.As calls were using new(*NoDataInSecretError) which creates a **NoDataInSecretError, but the error is a value type. This prevented the error from being matched, causing PreprovisioningNetworkData to return an error instead of empty data when the networkData key is missing from a secret.

(cherry picked from commit 4c5261b)

[openshift-ci-robot]

@elfosardo: This pull request references Jira Issue OCPBUGS-70265, which is invalid:

• expected the bug to target the "4.22.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

The errors.As calls were using new(*NoDataInSecretError) which creates a **NoDataInSecretError, but the error is a value type. This prevented the error from being matched, causing PreprovisioningNetworkData to return an error instead of empty data when the networkData key is missing from a secret.

(cherry picked from commit 4c5261b)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[elfosardo]

/hold

[elfosardo]

/jira refresh

[openshift-ci-robot]

@elfosardo: This pull request references Jira Issue OCPBUGS-70265, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.22.0) matches configured target version for branch (4.22.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @jadhaj

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elfosardo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [elfosardo]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jadhaj]

/verified by @jadhaj

[openshift-ci-robot]

@jadhaj: This PR has been marked as verified by @jadhaj.

Details

In response to this:

/verified by @jadhaj

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

@elfosardo: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/okd-scos-images	827259e	link	true	/test okd-scos-images

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[elfosardo]

this works, waiting for the upstream change to merge metal3-io#2890