Skip to content

aggregation: remove Cluster should remain functional during upgrade from always passing #4841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
stbenjam wants to merge 1 commit into
base: main
Choose a base branch
from
+0 −6
Open

aggregation: remove Cluster should remain functional during upgrade from always passing #4841

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions pkg/jobrunaggregator/jobrunaggregatoranalyzer/pass_fail.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -689,12 +689,6 @@ func testShouldAlwaysPass(jobName, testName, testSuiteName string) string {
return "step graph tests are added by ci and are not useful for aggregation"
}

if strings.Contains(testName, `Cluster should remain functional during upgrade`) {
// this test is a side-effect of other tests. For the purpose of aggregation, we can have each individual job run
// fail this test, but the aggregated output can be successful.
return "this test is a side-effect of other tests"
}

if strings.HasSuffix(testName, "-gather-azure-cli container test") {
// this is only for gathering artifacts.
return "used only to collect artifacts"
Expand Down