Skip to content

Conversation

@openshift-cherrypick-robot

This is an automated cherry-pick of #1844

/assign lwan-wanglin

the intent of hostmount-anyuid is to allow a pod access to paths on the host.
The problem is, hostPath volumes aren't selinux relabeled, and there
are paths that the default selinux type `container_t` cannot access.

This breaks expectation, and makes pods that rely on hostmount-anyuid brittle to
selinux changes on the host (see https://issues.redhat.com/browse/OCPBUGS-55013)

Instead of relaxing permissions of all paths on the host, or increasing the
ability of container_t, we should trust pods that are granted access to this already powerful
SCC to use its power fully.

Signed-off-by: Peter Hunt <pehunt@redhat.com>
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: Jira Issue OCPBUGS-56266 has been cloned as Jira Issue OCPBUGS-63119. Will retitle bug to link to clone.
/retitle [release-4.18] OCPBUGS-63119: SCC: add hostmount-anyuid-v2

In response to this:

This is an automated cherry-pick of #1844

/assign lwan-wanglin

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai
Copy link

coderabbitai bot commented Oct 15, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci bot changed the title [release-4.18] OCPBUGS-56266: SCC: add hostmount-anyuid-v2 [release-4.18] OCPBUGS-63119: SCC: add hostmount-anyuid-v2 Oct 15, 2025
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Oct 15, 2025
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-63119, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.18.z) matches configured target version for branch (4.18.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-56266 is in the state Closed (Done-Errata), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-56266 targets the "4.19.0" version, which is one of the valid target versions: 4.19.0, 4.19.z
  • bug has dependents

Requesting review from QA contact:
/cc @sergiordlr

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is an automated cherry-pick of #1844

/assign lwan-wanglin

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@lwan-wanglin
Copy link

lwan-wanglin commented Oct 16, 2025

The background is that one of mco pr was backported to 4.18 and 4.17, which caused pods to fail mounting certain hostPaths when using the hostmount-anyuid SCC. Therefore, this PR also needs to be backported to 4.18 and 4.17
/cc @sergiordlr to review

@openshift-ci openshift-ci bot requested a review from vrutkovs October 16, 2025 08:48
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 16, 2025

@lwan-wanglin: GitHub didn't allow me to request PR reviews from the following users: to, review.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

The background is that one of mco pr was backported to 4.18 and 4.17, which caused pods to fail mounting certain hostPaths when using the hostmount-anyuid SCC. Therefore, this PR also needs to be backported to 4.18 and 4.17
/cc @sergiordlr @vrutkovs to review

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@lwan-wanglin
Copy link

/retest

@lwan-wanglin
Copy link

/cc @vrutkovs could you apporve it?
The background is that one of openshift/machine-config-operator#4933 pr was backported to 4.18 and 4.17, which caused pods to fail mounting certain hostPaths when using the hostmount-anyuid SCC. Therefore, this PR also needs to be backported to 4.18 and 4.17

@lwan-wanglin
Copy link

/retest

@vrutkovs
Copy link
Member

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 21, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, vrutkovs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 21, 2025
@lwan-wanglin
Copy link

lwan-wanglin commented Oct 21, 2025

@Prashanth684 Could you please add the lgtm and any other required labels? Thanks!

@lwan-wanglin
Copy link

/backport-risk-assessed

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 21, 2025

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@Prashanth684 Prashanth684 added lgtm Indicates that a PR is ready to be merged. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. labels Oct 27, 2025
@Prashanth684
Copy link

/verified by @lwan-wanglin

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Oct 27, 2025
@openshift-ci-robot
Copy link

@Prashanth684: This PR has been marked as verified by @lwan-wanglin.

In response to this:

/verified by @lwan-wanglin

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-bot openshift-merge-bot bot merged commit bac8a7c into openshift:release-4.18 Oct 27, 2025
13 checks passed
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: Jira Issue Verification Checks: Jira Issue OCPBUGS-63119
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-63119 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

In response to this:

This is an automated cherry-pick of #1844

/assign lwan-wanglin

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@lwan-wanglin
Copy link

/cherry-pick release-4.17

@openshift-cherrypick-robot
Copy link
Author

@lwan-wanglin: new pull request created: #1954

In response to this:

/cherry-pick release-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.18.0-0.nightly-2025-10-28-171242

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants