no-jira: Add priority field to prevent early shutdown #572
Conversation
openshift-ci
bot
added
the
needs-ok-to-test
|
Hi @CoreyCook8. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
👋 @ingvagabund you're the recommended reviewer here, would you be able to take a look at these? 🙏 We opened 4 PRs to fix this issue, one has been merged. I linked the other two below: openshift/cluster-kube-controller-manager-operator#865 |
|
/ok-to-test |
openshift-ci
bot
added
ok-to-test
| - mountPath: /etc/kubernetes/static-pod-certs | ||
| name: cert-dir | ||
| hostNetwork: true | ||
| priority: 2000001000 |
There was a problem hiding this comment.
Priority admission plugin mentions:
// if the pod contained a priority that differs from the one computed from the priority class, error
As long as the priority of system-node-critical PC does not change we are ok.
There was a problem hiding this comment.
@CoreyCook8 we need to introduce a new e2e test under https://github.com/openshift/origin/tree/main/test/extended to make sure the priority number does not change for system-node-critical. Would you be willing to go through this exercise? :)
There was a problem hiding this comment.
👋 I created openshift/origin#30268 if you don't mind taking a look and giving an ok-to-test?
|
/approve |
|
/retest-required |
openshift-ci
bot
added
lgtm
|
/verified by ci/prow/e2e-aws-operator The operator needs to see the mirrored pod up and running. The KA admission plugin will fail when the priority class number is different from what is normally defined. |
openshift-ci-robot
added
the
verified
|
@ingvagabund: This PR has been marked as verified by In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/re-title no-jira: Add priority field to prevent early shutdown |
|
@CoreyCook8 the unit tests are failing |
|
/retitle no-jira: Add priority field to prevent early shutdown |
openshift-ci
bot
changed the title
openshift-ci-robot
added
the
jira/valid-reference
|
@CoreyCook8: This pull request explicitly references no jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
removed
the
verified
|
@CoreyCook8: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/lgtm |
|
/verified by ci/prow/e2e-aws-operator |
openshift-ci-robot
added
the
verified
|
@ingvagabund: This PR has been marked as verified by In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CoreyCook8, ingvagabund The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/cherry-pick release-4.20 |
|
@dinhxuanvu: new pull request created: #586 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
5 participants
Based on the issue described here : kubernetes/kubernetes#133442
priorityClassName is currently ignored by Kubelet for static pod files so setting this value has no impact on the gracefulShutdown order causing the static pods to start to be killed as soon as shutdown begins.
To prevent this we must set priority explicitly