hack/cluster-version-util/task_graph: Task-node granularity #1221
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wking The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
wking
force-pushed
the
task-node-granularity
branch
from
f61fa93 to
46d4020
Compare
Make it easier to think about task-nodes as opaque objects by assigning them runlevel and component properties, and using that information to label names in the rendered graph.
Using a similar process to cde8d50 (docs/user/reconciliation: Document release-image application, 2019-06-10, openshift#201) and 4353698 (docs/user/tasks-*by-number-and-component.svg: Update to 4.13, 2023-07-25, openshift#949), but for 4.20.0-ec.5. The SVGs were generated with the new --granularity flag set to 'manifest', to make it easier for cluster operator maintainers to understand how their manifests are collected into task nodes: $ go build ./hack/cluster-version-util $ mkdir /tmp/release $ oc image extract quay.io/openshift-release-dev/ocp-release:4.20.0-ec.5-x86_64[-1] --path /:/tmp/release $ mkdir /tmp/release/manifests $ ./cluster-version-util task-graph --granularity manifest /tmp/release | dot -Tsvg >docs/user/tasks-by-number-and-component.svg $ ./cluster-version-util task-graph --granularity manifest --parallel flatten-by-number-and-component /tmp/release | dot -Tsvg >docs/user/tasks-flatten-by-number-and-component.svg using: $ go version go version go1.23.6 linux/amd64 $ dot -V dot - graphviz version 2.43.0 (0)
wking
force-pushed
the
task-node-granularity
branch
from
46d4020 to
e89c7a9
Compare
|
@wking: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/cc but fails unit tests |
|
/uncc |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-opening #991, but against
maininstead ofmaster, now that the dev branch has been renamed.