-
Notifications
You must be signed in to change notification settings - Fork 668
OCPBUGS-70329: Auto-linkify URLs in status card alert messages #15880
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Wrap alert messages in StatusItem with LinkifyExternal to automatically convert URLs to clickable hyperlinks. This makes the status card behavior consistent with the notification drawer, which already uses LinkifyExternal for alert descriptions. This was discovered when investigating why the InsightsDisabled alert from the insights-operator displayed its documentation URL as plain text instead of a clickable link in the cluster dashboard status card.
WalkthroughThe AlertItem component now imports the LinkifyExternal utility and wraps alert messages within it, modifying rendering to process URLs as external links. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes ✨ Finishing touches
📜 Recent review detailsConfiguration used: Organization UI Review profile: CHILL Plan: Pro Cache: Disabled due to data retention organization setting Knowledge base: Disabled due to 📒 Files selected for processing (1)
🧰 Additional context used📓 Path-based instructions (1)**⚙️ CodeRabbit configuration file
Files:
🧬 Code graph analysis (1)frontend/packages/console-shared/src/components/dashboard/status-card/AlertItem.tsx (1)
🔇 Additional comments (2)
Comment |
|
/retest (fail is unrelated to my change) |
1 similar comment
|
/retest (fail is unrelated to my change) |
logonoff
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
|
/retitle OCPBUGS-70329: Auto-linkify URLs in status card alert messages |
|
@adereis: This pull request references Jira Issue OCPBUGS-70329, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
|
@logonoff: This pull request references Jira Issue OCPBUGS-70329, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
The issues are with the tests. The failures are unrelated to my changes:
and
/retest |
|
@adereis: This pull request references Jira Issue OCPBUGS-70329, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/retest-required |
|
/retest (failing tests are unrelated to my change) |
spadgett
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adereis, spadgett The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@adereis: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |

Summary
LinkifyExternalcomponent to automatically convert URLs in status card alert messages into clickable linksTest plan
Screenshot of the problem being fixed:
