Skip to content

OLS-2114: Add dataverse-exporter to bundle #1012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 14, 2025
Merged

OLS-2114: Add dataverse-exporter to bundle #1012

merged 2 commits into from
Oct 14, 2025

Conversation

onmete
Copy link
Contributor

@onmete onmete commented Oct 2, 2025

Description

Add dataverse-exporter to bundle

Type of change

  • Refactor
  • New feature
  • Bug fix
  • CVE fix
  • Optimization
  • Documentation Update
  • Configuration Update
  • Bump-up dependent library

Related Tickets & Documents

  • Related Issue #
  • Closes #

Checklist before requesting a review

  • I have performed a self-review of my code.
  • PR has passed all pre-merge test jobs.
  • If it is a core feature, I have added thorough tests.

Testing

  • Please provide detailed steps to perform tests related to this code change.
  • How were the fix/results from this change verified? Please provide relevant screenshots or results.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 2, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 2, 2025 •
edited by openshift-ci bot
Loading

@onmete: This pull request references OLS-2114 which is a valid jira issue.

In response to this:

Description

Add dataverse-exporter to bundle

Type of change

  • Refactor
  • New feature
  • Bug fix
  • CVE fix
  • Optimization
  • Documentation Update
  • Configuration Update
  • Bump-up dependent library

Related Tickets & Documents

  • Related Issue #
  • Closes #

Checklist before requesting a review

  • I have performed a self-review of my code.
  • PR has passed all pre-merge test jobs.
  • If it is a core feature, I have added thorough tests.

Testing

  • Please provide detailed steps to perform tests related to this code change.
  • How were the fix/results from this change verified? Please provide relevant screenshots or results.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from bparees and raptorsun October 2, 2025 11:18
@onmete
Copy link
Contributor Author

onmete commented Oct 2, 2025

/retest

@raptorsun
Copy link
Contributor

It seems this is a first step of https://issues.redhat.com/browse/OLS-1979 .
Shall we put the rest of the logics replacing the old datacollector by dataverse-exporter and merge it then?

@raptorsun
Copy link
Contributor

as dataverse exporter becomes part of the related image list, we will merge this when the dataverse exporter image is ready to release.

@onmete
Copy link
Contributor Author

onmete commented Oct 6, 2025

/retest

@onmete onmete force-pushed the add-dataverse-exporter-to-bundle branch from d717088 to 23f7521 Compare October 6, 2025 09:13
@raptorsun
Copy link
Contributor

/retest

@onmete onmete force-pushed the add-dataverse-exporter-to-bundle branch from d1b2613 to 77af89c Compare October 6, 2025 11:12
@onmete
Copy link
Contributor Author

onmete commented Oct 6, 2025

/retest

2 similar comments
@raptorsun
Copy link
Contributor

/retest

@raptorsun
Copy link
Contributor

/retest

@onmete onmete force-pushed the add-dataverse-exporter-to-bundle branch 2 times, most recently from 55bfa3a to 2b17a41 Compare October 10, 2025 14:38
@onmete onmete force-pushed the add-dataverse-exporter-to-bundle branch from 2b17a41 to d2c6ba4 Compare October 10, 2025 14:44
raptorsun
raptorsun reviewed Oct 13, 2025
View reviewed changes
bundle/manifests/lightspeed-operator.clusterserviceversion.yaml
- --console-image=quay.io/openshift-lightspeed/lightspeed-console-plugin:latest
- --postgres-image=registry.redhat.io/rhel9/postgresql-16@sha256:42f385ac3c9b8913426da7c57e70bc6617cd237aaf697c667f6385a8c0b0118b
- --openshift-mcp-server-image=quay.io/redhat-user-workloads/crt-nshift-lightspeed-tenant/openshift-mcp-server@sha256:3a035744b772104c6c592acf8a813daced19362667ed6dab73a00d17eb9c3a43
- --dataverse-exporter-image=quay.io/redhat-user-workloads/crt-nshift-lightspeed-tenant/lightspeed-to-dataverse-exporter@sha256:ccb6705a5e7ff0c4d371dc72dc8cf319574a2d64bcc0a89ccc7130f626656722
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need add dataverse exporter image to the related image list by the end of this file, too.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added

@onmete
Copy link
Contributor Author

onmete commented Oct 13, 2025

/retest

@raptorsun
Copy link
Contributor

/retest
on-pull-request cannot fetch this git repo...

@raptorsun
Copy link
Contributor

/retest

@raptorsun
Copy link
Contributor

/lgtm
/approve
/retest

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 13, 2025
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Oct 13, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: raptorsun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 13, 2025
@onmete
Copy link
Contributor Author

onmete commented Oct 14, 2025

/retest

@raptorsun
Copy link
Contributor

/override "Red Hat Konflux / operator-e2e-tests-417 / ols-bundle"
/override "Red Hat Konflux / service-e2e-tests-417 / ols-bundle"
operator in the bundle still missing the new flag flag provided but not defined: -dataverse-exporter-image
we need update the related_images.json to use the new operator image to make the konflux bundle test passing again

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Oct 14, 2025

@raptorsun: Overrode contexts on behalf of raptorsun: Red Hat Konflux / operator-e2e-tests-417 / ols-bundle, Red Hat Konflux / service-e2e-tests-417 / ols-bundle

In response to this:

/override "Red Hat Konflux / operator-e2e-tests-417 / ols-bundle"
/override "Red Hat Konflux / service-e2e-tests-417 / ols-bundle"
operator in the bundle still missing the new flag flag provided but not defined: -dataverse-exporter-image
we need update the related_images.json to use the new operator image to make the konflux bundle test passing again

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Oct 14, 2025

@onmete: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit dafe8a6 into openshift:main Oct 14, 2025
16 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bparees bparees Awaiting requested review from bparees

1 more reviewer

@raptorsun raptorsun raptorsun left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@raptorsun raptorsun

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@onmete @openshift-ci-robot @raptorsun