Skip to content

OLS-2118: Support disabling the OCP index in lightspeed-operator - test #1040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 14, 2025
Merged

OLS-2118: Support disabling the OCP index in lightspeed-operator - test #1040

merged 1 commit into from
Oct 14, 2025

Conversation

syedriko
Copy link
Contributor

@syedriko syedriko commented Oct 7, 2025

Description

A unit test for disabling the OCP index with the byokRAGOnly flag. A follow-up PR to #1009.

Type of change

  • Refactor
  • New feature
  • Bug fix
  • CVE fix
  • Optimization
  • Documentation Update
  • Configuration Update
  • Bump-up dependent library

Related Tickets & Documents

Checklist before requesting a review

  • I have performed a self-review of my code.
  • PR has passed all pre-merge test jobs.
  • If it is a core feature, I have added thorough tests.

Testing

  • Please provide detailed steps to perform tests related to this code change.
  • How were the fix/results from this change verified? Please provide relevant screenshots or results.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 7, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 7, 2025 •
edited by openshift-ci bot
Loading

@syedriko: This pull request references OLS-2118 which is a valid jira issue.

In response to this:

Description

A unit test for disabling the OCP index with the byokRAGOnly flag. A follow-up PR to #1009.

Type of change

  • Refactor
  • New feature
  • Bug fix
  • CVE fix
  • Optimization
  • Documentation Update
  • Configuration Update
  • Bump-up dependent library

Related Tickets & Documents

Checklist before requesting a review

  • I have performed a self-review of my code.
  • PR has passed all pre-merge test jobs.
  • If it is a core feature, I have added thorough tests.

Testing

  • Please provide detailed steps to perform tests related to this code change.
  • How were the fix/results from this change verified? Please provide relevant screenshots or results.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from joshuawilson and xrajesh October 7, 2025 20:30
@raptorsun
Copy link
Contributor

/lgtm
/approve

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 10, 2025
@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 10, 2025
@syedriko syedriko force-pushed the syedriko-ols-2118-test branch from a4da869 to 25215bb Compare October 10, 2025 18:13
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 10, 2025
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 10, 2025
xrajesh
xrajesh reviewed Oct 14, 2025
View reviewed changes
internal/controller/ols_app_server_assets_test.go
Expect(err).NotTo(HaveOccurred())

// Testing for equality means the only RAG source is the one specified via the BYOK
// mechanism above. The OCP RAG database is not included.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@syedriko This is not checking for - The OCP RAG database is not included

Copy link
Contributor Author

@syedriko syedriko Oct 14, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how so? it checks that "ansible-docs-2_18" is the only included database.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes - ignore please - I was thinking we needed a negative case for not having default index.

@syedriko
Copy link
Contributor Author

/test unit

@syedriko syedriko force-pushed the syedriko-ols-2118-test branch from 25215bb to 42519d0 Compare October 14, 2025 15:17
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Oct 14, 2025

@syedriko: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@xrajesh
Copy link
Contributor

xrajesh commented Oct 14, 2025

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 14, 2025
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Oct 14, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: raptorsun, xrajesh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit bbe4ee0 into openshift:main Oct 14, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xrajesh xrajesh xrajesh left review comments

@joshuawilson joshuawilson Awaiting requested review from joshuawilson

Assignees

@raptorsun raptorsun

@xrajesh xrajesh

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@syedriko @openshift-ci-robot @raptorsun @xrajesh @openshift-merge-robot