OLS-2166: even in debug mode, OLS server never indicates BYOK indexes are loaded #1049

syedriko · 2025-10-09T04:10:16Z

Description

Added a new field to the OLS RAG configuration - product_docs_origin -

ols_config:
  reference_content:
    indexes:
      product_docs_origin

that the OLS will use to identify the source of the RAG database. For BYOK RAG sources, product_docs_origin is set to the BYOK image name:tag. For OCP docs, it is set to "Red Hat OpenShift x.y documentation"
The corresponding service PR is openshift/lightspeed-service#2630

Type of change

Related Tickets & Documents

Related Issue #
Closes # https://issues.redhat.com/browse/OLS-2166

Checklist before requesting a review

I have performed a self-review of my code.
PR has passed all pre-merge test jobs.
If it is a core feature, I have added thorough tests.

Testing

Please provide detailed steps to perform tests related to this code change.
How were the fix/results from this change verified? Please provide relevant screenshots or results.

openshift-ci-robot · 2025-10-09T04:10:21Z

openshift-ci-robot · 2025-10-09T04:15:05Z

openshift-ci-robot · 2025-10-09T04:15:26Z

openshift-ci-robot · 2025-10-09T04:16:39Z

@syedriko: This pull request references OLS-2166 which is a valid jira issue.

In response to this:

Description

Added a new field to the OLS RAG configuration - product_docs_origin -
ols_config:
 reference_content:
   indexes:
     product_docs_origin
that the OLS will use to identify the source of the RAG database. For BYOK RAG sources, product_docs_origin is set to the BYOK image name:tag. For OCP docs, it is set to "Red Hat OpenShift x.y documentation"

Type of change

Refactor

New feature

Bug fix

CVE fix

Optimization

Documentation Update

Configuration Update

Bump-up dependent library

Related Tickets & Documents

Related Issue #

Closes # https://issues.redhat.com/browse/OLS-2166

Checklist before requesting a review

I have performed a self-review of my code.

PR has passed all pre-merge test jobs.

If it is a core feature, I have added thorough tests.

Testing

Please provide detailed steps to perform tests related to this code change.

How were the fix/results from this change verified? Please provide relevant screenshots or results.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2025-10-09T04:34:08Z

@syedriko: This pull request references OLS-2166 which is a valid jira issue.

In response to this:

Description

Added a new field to the OLS RAG configuration - product_docs_origin -
ols_config:
 reference_content:
   indexes:
     product_docs_origin
that the OLS will use to identify the source of the RAG database. For BYOK RAG sources, product_docs_origin is set to the BYOK image name:tag. For OCP docs, it is set to "Red Hat OpenShift x.y documentation"
The corresponding service PR is openshift/lightspeed-service#2630

Type of change

Refactor

New feature

Bug fix

CVE fix

Optimization

Documentation Update

Configuration Update

Bump-up dependent library

Related Tickets & Documents

Related Issue #

Closes # https://issues.redhat.com/browse/OLS-2166

Checklist before requesting a review

I have performed a self-review of my code.

PR has passed all pre-merge test jobs.

If it is a core feature, I have added thorough tests.

Testing

Please provide detailed steps to perform tests related to this code change.

How were the fix/results from this change verified? Please provide relevant screenshots or results.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

syedriko · 2025-10-09T04:34:19Z

/retest

syedriko · 2025-10-09T19:11:53Z

/retest

… are loaded

syedriko · 2025-10-10T20:43:01Z

/retest

xrajesh · 2025-10-12T18:02:13Z

internal/controller/ols_app_server_assets.go

 		referenceIndex := ReferenceIndex{
 			ProductDocsIndexPath: filepath.Join(RAGVolumeMountPath, fmt.Sprintf("rag-%d", i)),
 			ProductDocsIndexId:   index.IndexID,
+			ProductDocsOrigin:    index.Image,


@syedriko What will be the indexOrigin name for BYOK images ?

For a BYOK image, its ProductDocsOrigin will be its image:tag. For example,

ols: rag: - image: quay.io/openshift-lightspeed-test/assisted-installer-guide:2025-1

will log

[ols.src.rag_index.index_loader:index_loader.py:148] INFO: Loading vector index #0 from quay.io/openshift-lightspeed-test/assisted-installer-guide:2025-1... ... [ols.src.rag_index.index_loader:index_loader.py:148] INFO: Loading vector index #1 from Red Hat OpenShift 4.19 documentation...

raptorsun · 2025-10-13T15:57:57Z

/lgtm
/approve

/test bundle-e2e-4-19

openshift-ci · 2025-10-13T15:58:19Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: raptorsun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [raptorsun]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci · 2025-10-13T17:36:45Z

@syedriko: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

syedriko · 2025-10-13T17:55:25Z

/retest

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 9, 2025

openshift-ci bot requested review from bparees and raptorsun October 9, 2025 04:11

syedriko marked this pull request as draft October 9, 2025 04:15

openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 9, 2025

syedriko mentioned this pull request Oct 9, 2025

OLS-2166: even in debug mode, OLS server never indicates BYOK indexes are loaded openshift/lightspeed-service#2630

Merged

14 tasks

syedriko marked this pull request as ready for review October 9, 2025 19:11

openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 9, 2025

openshift-ci bot requested a review from joshuawilson October 9, 2025 19:12

OLS-2166: even in debug mode, OLS server never indicates BYOK indexes…

adc70d0

… are loaded

syedriko force-pushed the syedriko-ols-2166 branch from 247c3bb to adc70d0 Compare October 10, 2025 18:33

xrajesh reviewed Oct 12, 2025

View reviewed changes

openshift-ci bot assigned raptorsun Oct 13, 2025

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 13, 2025

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 13, 2025

openshift-merge-bot bot merged commit 3dbe16c into openshift:main Oct 13, 2025
11 checks passed

OLS-2166: even in debug mode, OLS server never indicates BYOK indexes are loaded #1049

OLS-2166: even in debug mode, OLS server never indicates BYOK indexes are loaded #1049

Uh oh!

Conversation

syedriko commented Oct 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Type of change

Related Tickets & Documents

Checklist before requesting a review

Testing

Uh oh!

openshift-ci-robot commented Oct 9, 2025 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Type of change

Related Tickets & Documents

Checklist before requesting a review

Testing

Uh oh!

openshift-ci-robot commented Oct 9, 2025 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Type of change

Related Tickets & Documents

Checklist before requesting a review

Testing

Uh oh!

openshift-ci-robot commented Oct 9, 2025 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Type of change

Related Tickets & Documents

Checklist before requesting a review

Testing

Uh oh!

openshift-ci-robot commented Oct 9, 2025 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Type of change

Related Tickets & Documents

Checklist before requesting a review

Testing

Uh oh!

openshift-ci-robot commented Oct 9, 2025 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Type of change

Related Tickets & Documents

Checklist before requesting a review

Testing

Uh oh!

syedriko commented Oct 9, 2025

Uh oh!

syedriko commented Oct 9, 2025

Uh oh!

syedriko commented Oct 10, 2025

Uh oh!

xrajesh Oct 12, 2025

Choose a reason for hiding this comment

Uh oh!

syedriko Oct 12, 2025

Choose a reason for hiding this comment

Uh oh!

raptorsun commented Oct 13, 2025

Uh oh!

openshift-ci bot commented Oct 13, 2025

Uh oh!

openshift-ci bot commented Oct 13, 2025

Uh oh!

syedriko commented Oct 13, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

syedriko commented Oct 9, 2025 •

edited

Loading

openshift-ci-robot commented Oct 9, 2025 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Oct 9, 2025 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Oct 9, 2025 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Oct 9, 2025 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Oct 9, 2025 •

edited by openshift-ci bot

Loading