Skip to content

Conversation

sriroopar
Copy link
Contributor

@sriroopar sriroopar commented Sep 23, 2025

Description

Functionality has been added in order to ensure that the reconciliation happens in the postgres pod by watching the config for deletion of ca certs. This will allow the e2e test to run successfully.

Type of change

  • Refactor
  • New feature
  • Bug fix
  • CVE fix
  • Optimization
  • Documentation Update
  • Configuration Update
  • Bump-up dependent library

Related Tickets & Documents

Checklist before requesting a review

  • I have performed a self-review of my code.
  • PR has passed all pre-merge test jobs.
  • If it is a core feature, I have added thorough tests.

Testing

  • Please provide detailed steps to perform tests related to this code change.
    Functionality was verified by watching reconciliation activity when ca cert was intentionally deleted.

  • How were the fix/results from this change verified? Please provide relevant screenshots or results.

The fix was verified by deleting the olsconfig-service-ca signing-key certificate/ olsconfig ca.crt configmap, and the pods were observed for rollouts with updated cert.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 23, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 23, 2025

@sriroopar: This pull request references OLS-1775 which is a valid jira issue.

In response to this:

Description

Functionality has been added in order to ensure that the reconciliation happens in the postgres pod by watching the config for deletion of ca certs. This will allow the e2e test to run successfully.

Type of change

  • Refactor
  • New feature
  • Bug fix
  • CVE fix
  • Optimization
  • Documentation Update
  • Configuration Update
  • Bump-up dependent library

Related Tickets & Documents

Checklist before requesting a review

  • I have performed a self-review of my code.
  • PR has passed all pre-merge test jobs.
  • If it is a core feature, I have added thorough tests.

Testing

  • Please provide detailed steps to perform tests related to this code change.
    Functionality was verified by watching reconciliation activity when ca cert was intentionally deleted.

  • How were the fix/results from this change verified? Please provide relevant screenshots or results.

The fix was verified by deleting the olsconfig-service-ca signing-key certificate, and the pods were observed for rollouts with updated cert.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from bparees and xrajesh September 23, 2025 19:01
Copy link

openshift-ci bot commented Sep 23, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign joshuawilson for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sriroopar
Copy link
Contributor Author

/retest

3 similar comments
@sriroopar
Copy link
Contributor Author

/retest

@sriroopar
Copy link
Contributor Author

/retest

@sriroopar
Copy link
Contributor Author

/retest

@sriroopar
Copy link
Contributor Author

/test bundle-e2e-4-18

@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 1, 2025

@sriroopar: This pull request references OLS-1775 which is a valid jira issue.

In response to this:

Description

Functionality has been added in order to ensure that the reconciliation happens in the postgres pod by watching the config for deletion of ca certs. This will allow the e2e test to run successfully.

Type of change

  • Refactor
  • New feature
  • Bug fix
  • CVE fix
  • Optimization
  • Documentation Update
  • Configuration Update
  • Bump-up dependent library

Related Tickets & Documents

Checklist before requesting a review

  • I have performed a self-review of my code.
  • PR has passed all pre-merge test jobs.
  • If it is a core feature, I have added thorough tests.

Testing

  • Please provide detailed steps to perform tests related to this code change.
    Functionality was verified by watching reconciliation activity when ca cert was intentionally deleted.

  • How were the fix/results from this change verified? Please provide relevant screenshots or results.

The fix was verified by deleting the olsconfig-service-ca signing-key certificate/ olsconfig ca.crt configmap, and the pods were observed for rollouts with updated cert.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@sriroopar sriroopar force-pushed the postgres-cert-rotation branch from 5d8df32 to 02cf600 Compare October 1, 2025 12:31
@sriroopar sriroopar force-pushed the postgres-cert-rotation branch from 02cf600 to 3162eff Compare October 1, 2025 12:58
Copy link

openshift-ci bot commented Oct 1, 2025

@sriroopar: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/bundle-e2e-4-18 51d0e9d link true /test bundle-e2e-4-18

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants