Skip to content

Conversation

thoraxe
Copy link
Contributor

@thoraxe thoraxe commented Aug 11, 2025

Description

This stores the OLSConfig with both transcripts and feedback to help with understanding how the service is being used.

Type of change

  • Refactor
  • New feature
  • Bug fix
  • CVE fix
  • Optimization
  • Documentation Update
  • Configuration Update
  • Bump-up dependent library
  • Bump-up library or tool used for development (does not change the final image)
  • CI configuration change
  • Konflux configuration change

Related Tickets & Documents

I don't think we ended up creating issues for this feature yet.

Checklist before requesting a review

  • I have performed a self-review of my code.
  • PR has passed all pre-merge test jobs.
  • If it is a core feature, I have added thorough tests.

Testing

Added tests that match the current framework.

Code by Claude.

@openshift-ci openshift-ci bot requested review from onmete and xrajesh August 11, 2025 15:33
Copy link

openshift-ci bot commented Aug 11, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign bparees for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@onmete
Copy link
Contributor

onmete commented Aug 12, 2025

/hold

Discussion about the ideal approach.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 12, 2025
Copy link

openshift-ci bot commented Sep 29, 2025

@thoraxe: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/4.18-e2e-ols-cluster 5697dc4 link true /test 4.18-e2e-ols-cluster
ci/prow/verify 5697dc4 link true /test verify
ci/prow/e2e-ols-cluster 5697dc4 link true /test e2e-ols-cluster

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants