-
Notifications
You must be signed in to change notification settings - Fork 52
OLS-1980: Add autodiscovery for indexID value #2626
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@syedriko: This pull request references OLS-1980 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
7d31f9c
to
90b665c
Compare
90b665c
to
39d3b30
Compare
/retest |
/test e2e-ols-cluster |
/retest |
/retest |
@syedriko: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Description
Make the Faiss index id for RAG databases optional as there's usually no need to specify it since there's only one index in a database anyway.
Type of change
Related Tickets & Documents
Checklist before requesting a review
Testing