[WIP] NO-ISSUE: Fix TestMissingImageIsRebuilt goroutine safety issue

[umohnani8]

- What I did
Replace require.NoError() with assert.NoError() in background goroutines that stream pod logs. require.NoError() calls t.FailNow() which internally calls runtime.Goexit(), terminating only the current goroutine without stopping the test. This causes undefined behavior and test failures.

assert.NoError() marks the test as failed without calling Goexit(), making it safe to use in goroutines.

This fixes the test failure where log streaming goroutines would silently fail without properly reporting errors.

- How to verify it
Failures in the TestMissingImageIsRebuilt should be reported in the logs

- Description for the changelog
Fix logs for TestMissingImageIsRebuilt

[openshift-ci-robot]

@umohnani8: This pull request explicitly references no jira issue.

Details

In response to this:

- What I did
Replace require.NoError() with assert.NoError() in background goroutines that stream pod logs. require.NoError() calls t.FailNow() which internally calls runtime.Goexit(), terminating only the current goroutine without stopping the test. This causes undefined behavior and test failures.

assert.NoError() marks the test as failed without calling Goexit(), making it safe to use in goroutines.

This fixes the test failure where log streaming goroutines would silently fail without properly reporting errors.

- How to verify it
Failures in the TestMissingImageIsRebuilt should be reported in the logs

- Description for the changelog
Fix logs for TestMissingImageIsRebuilt

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[umohnani8]

/test e2e-gcp-op-ocl

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: umohnani8

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [umohnani8]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[umohnani8]

/test e2e-gcp-op-ocl

[umohnani8]

/test e2e-gcp-op-ocl

[umohnani8]

/test e2e-gcp-op-ocl

[umohnani8]

/test e2e-gcp-op-ocl

[umohnani8]

/test e2e-gcp-op-ocl

[umohnani8]

/test e2e-gcp-op-ocl

[openshift-ci]

@umohnani8: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-gcp-op-2of2	5f2f254	link	true	/test e2e-gcp-op-2of2
ci/prow/e2e-aws-ovn	5f2f254	link	true	/test e2e-aws-ovn
ci/prow/e2e-gcp-op-1of2	5f2f254	link	true	/test e2e-gcp-op-1of2
ci/prow/e2e-hypershift	5f2f254	link	true	/test e2e-hypershift
ci/prow/e2e-aws-ovn-upgrade	5f2f254	link	true	/test e2e-aws-ovn-upgrade
ci/prow/bootstrap-unit	5f2f254	link	false	/test bootstrap-unit
ci/prow/okd-scos-images	704caa0	link	true	/test okd-scos-images
ci/prow/e2e-gcp-op-single-node	5f2f254	link	true	/test e2e-gcp-op-single-node
ci/prow/e2e-gcp-op-ocl	704caa0	link	false	/test e2e-gcp-op-ocl

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.