Skip to content

[release-4.20] OCPBUGS-70322: Skip boot image updates if arch annotation is not found #5525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-bot merged 3 commits into from
Jan 7, 2026
Merged

[release-4.20] OCPBUGS-70322: Skip boot image updates if arch annotation is not found #5525

openshift-merge-bot merged 3 commits into from
Jan 7, 2026

Conversation

@djoshy
Copy link
Contributor

@djoshy djoshy commented Jan 5, 2026

Manual backport of #5513

djoshy added 3 commits January 5, 2026 09:46
@djoshy
controller: rename msbic to boot image controller
6cb9861 
This commit simplifies the name of the package as
the controller now deals with more than just the
standard machineset resources.
@djoshy
boot_image: add event based queueing
4a1982e
@djoshy
msbic: skip update if arch annotation not found
84ef367
@djoshy
Copy link
Contributor Author

djoshy commented Jan 5, 2026

/jira cherry-pick OCPBUGS-69965

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 5, 2026
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 5, 2026

@djoshy: Jira Issue OCPBUGS-69965 has been cloned as Jira Issue OCPBUGS-70322. Will retitle bug to link to clone.
/retitle OCPBUGS-70322: [release-4.20] Skip boot image updates if arch annotation is not found

Details

In response to this:

/jira cherry-pick OCPBUGS-69965

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot changed the title [release-4.20] Skip boot image updates if arch annotation is not found OCPBUGS-70322: [release-4.20] Skip boot image updates if arch annotation is not found Jan 5, 2026
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jan 5, 2026
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 5, 2026

@djoshy: This pull request references Jira Issue OCPBUGS-70322, which is invalid:

  • expected dependent Jira Issue OCPBUGS-69965 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is MODIFIED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Manual backport of #5513

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@djoshy djoshy changed the title OCPBUGS-70322: [release-4.20] Skip boot image updates if arch annotation is not found [release-4.20] OCPBUGS-70322: Skip boot image updates if arch annotation is not found Jan 5, 2026
@djoshy
Copy link
Contributor Author

djoshy commented Jan 5, 2026

/payload-job periodic-ci-openshift-release-master-nightly-4.20-e2e-gcp-ovn-serial periodic-ci-openshift-release-master-nightly-4.20-e2e-aws-ovn-serial-1of2 periodic-ci-openshift-release-master-nightly-4.20-e2e-aws-ovn-serial-2of2

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 5, 2026

@djoshy: trigger 3 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-nightly-4.20-e2e-gcp-ovn-serial
  • periodic-ci-openshift-release-master-nightly-4.20-e2e-aws-ovn-serial-1of2
  • periodic-ci-openshift-release-master-nightly-4.20-e2e-aws-ovn-serial-2of2

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/21e20630-ea66-11f0-915b-132a5ce1bded-0

yuqi-zhang
yuqi-zhang approved these changes Jan 6, 2026
View reviewed changes
Copy link
Contributor

@yuqi-zhang yuqi-zhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/label backport-risk-assessed

Seems like a sane backport. The main differences seem to be on the devex/test changes, which I honestly don't remember why they were in the 4.21 PR but shouldn't affect functionality here

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Jan 6, 2026
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 6, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 6, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: djoshy, yuqi-zhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@djoshy
Copy link
Contributor Author

djoshy commented Jan 6, 2026

/jira refresh

/verified by payloads

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Jan 6, 2026
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 6, 2026

@djoshy: This pull request references Jira Issue OCPBUGS-70322, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.20.z) matches configured target version for branch (4.20.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note text is set and does not match the template
  • dependent bug Jira Issue OCPBUGS-69965 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-69965 targets the "4.21.0" version, which is one of the valid target versions: 4.21.0
  • bug has dependents

Requesting review from QA contact:
/cc @sergiordlr

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

/jira refresh

/verified by payloads

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Jan 6, 2026
@openshift-ci openshift-ci bot requested a review from sergiordlr January 6, 2026 22:30
@djoshy
Copy link
Contributor Author

djoshy commented Jan 6, 2026

/verified by payloads

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Jan 6, 2026
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 6, 2026

@djoshy: This PR has been marked as verified by payloads.

Details

In response to this:

/verified by payloads

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 7, 2026

/retest-required

Remaining retests: 0 against base HEAD bf69ce3 and 2 for PR HEAD 84ef367 in total

@djoshy
Copy link
Contributor Author

djoshy commented Jan 7, 2026

/retest-required

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 7, 2026 •
edited
Loading

@djoshy: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/bootstrap-unit 84ef367 link false /test bootstrap-unit

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@djoshy
Copy link
Contributor Author

djoshy commented Jan 7, 2026

/retest-required

@openshift-merge-bot openshift-merge-bot bot merged commit 8af0c84 into openshift:release-4.20 Jan 7, 2026
14 of 15 checks passed
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 7, 2026

@djoshy: Jira Issue Verification Checks: Jira Issue OCPBUGS-70322
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-70322 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

Details

In response to this:

Manual backport of #5513

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-robot
Copy link
Contributor

openshift-merge-robot commented Jan 8, 2026

Fix included in accepted release 4.20.0-0.nightly-2026-01-08-043322

@djoshy djoshy deleted the 4.20-boot-image-controller-backport branch January 8, 2026 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yuqi-zhang yuqi-zhang yuqi-zhang approved these changes

@RishabhSaini RishabhSaini Awaiting requested review from RishabhSaini

@sergiordlr sergiordlr Awaiting requested review from sergiordlr

Assignees

@rbbratta rbbratta

@eurijon eurijon

@zhaozhanqi zhaozhanqi

@lyman9966 lyman9966

@anuragthehatter anuragthehatter

@sergiordlr sergiordlr

@imatza-rh imatza-rh

@rioliu-rh rioliu-rh

@mhanss mhanss

@ptalgulk01 ptalgulk01

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.