Skip to content

USHIFT-6427: Update script to wait for all containers to be ready in the pod #5979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
kasturinarra wants to merge 1 commit into
base: main
Choose a base branch
from
Open

USHIFT-6427: Update script to wait for all containers to be ready in the pod #5979

kasturinarra wants to merge 1 commit into from

Conversation

@kasturinarra
Copy link
Contributor

@kasturinarra kasturinarra commented Dec 24, 2025

currently the code just waits for pod to be running but there may be a possibility that all containers in the pod might not go to ready state, so updating the code to make sure it waits until all the containers in the pod are ready.

@kasturinarra kasturinarra marked this pull request as draft December 24, 2025 11:00
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 24, 2025
@openshift-ci openshift-ci bot requested review from agullon and jogeo December 24, 2025 11:00
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 24, 2025
@kasturinarra
Copy link
Contributor Author

kasturinarra commented Dec 24, 2025

/test e2e-aws-tests-bootc-release-arm

@kasturinarra kasturinarra changed the title Update script to wait for all containers to be ready in the pod USHIFT-6427: Update script to wait for all containers to be ready in the pod Dec 24, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Dec 24, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 24, 2025 •
edited by openshift-ci bot
Loading

@kasturinarra: This pull request references USHIFT-6427 which is a valid jira issue.

Details

In response to this:

currently the code just waits for pod to be running but there may be a possibility that all containers in the pod might not go to ready state, so updating the code to make sure it waits until all the containers in the pod are ready.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@kasturinarra
Copy link
Contributor Author

kasturinarra commented Dec 24, 2025

/test e2e-aws-tests-bootc-release-arm

ggiguash
ggiguash reviewed Dec 24, 2025
View reviewed changes
@kasturinarra
Copy link
Contributor Author

kasturinarra commented Dec 24, 2025

/test e2e-aws-tests-bootc-release-arm

@kasturinarra kasturinarra marked this pull request as ready for review December 24, 2025 16:21
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 24, 2025
@openshift-ci openshift-ci bot requested a review from jerpeter1 December 24, 2025 16:22
@agullon
Copy link
Contributor

agullon commented Dec 24, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 24, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 24, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: agullon, kasturinarra

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [agullon,kasturinarra]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ggiguash
Copy link
Contributor

ggiguash commented Dec 24, 2025

/test e2e-aws-tests-bootc-release
/test e2e-aws-tests-bootc-release-arm
/test e2e-aws-tests-release
/test e2e-aws-tests-release-arm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 24, 2025

@kasturinarra: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-tests-bootc-release 2553b1e link true /test e2e-aws-tests-bootc-release
ci/prow/e2e-aws-tests 2553b1e link true /test e2e-aws-tests
ci/prow/e2e-aws-tests-release 2553b1e link true /test e2e-aws-tests-release
ci/prow/e2e-aws-tests-release-arm 2553b1e link true /test e2e-aws-tests-release-arm

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@agullon agullon Awaiting requested review from agullon

@jogeo jogeo Awaiting requested review from jogeo

@jerpeter1 jerpeter1 Awaiting requested review from jerpeter1

1 more reviewer

@ggiguash ggiguash ggiguash left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@agullon agullon

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kasturinarra @openshift-ci-robot @agullon @ggiguash