Skip to content

Conversation

@bmeng
Copy link
Contributor

@bmeng bmeng commented Jul 14, 2025

No description provided.

@openshift-ci openshift-ci bot requested review from martinkennelly and trozet July 14, 2025 05:40
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 14, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bmeng

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 14, 2025

### For clusters running with version 4.13+

User can follow the OpenShift doc to expand the network IP address range.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use 'document' instead of 'doc'.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of 'network IP address range', we should say 'cluster subnet IP address range'.

Choosing a larger cluster network CIDR which can hold more subnets could prevent
this happening.

### For clusters running with version 4.13+

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you use 'onward' instead of using '+' to imply later versions?


User can follow the OpenShift doc to expand the network IP address range.

Refer: https://docs.redhat.com/en/documentation/openshift_container_platform/4.13/html/networking/configuring-cluster-network-range

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you know if this link remains true for all versions? If not, we can probably point to the release note mention for this change.

@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 11, 2025
@openshift-bot
Copy link

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci openshift-ci bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Dec 11, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 12, 2025

@bmeng: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/markdownlint 48c0523 link true /test markdownlint

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants