[NFV] OVS DPDK SRIOV IPV6 with 1 or 2 nodesets scenarios #660
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mnietoji The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
mnietoji
changed the title
mnietoji
force-pushed
the
nfv_ipv6
branch
4 times, most recently
from
dcd3c5e to
8cd7e21
Compare
mnietoji
force-pushed
the
nfv_ipv6
branch
4 times, most recently
from
b07ffb5 to
f97984c
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/2f91bf54d0db4b6cbfca37fbbc74c932 ✔️ noop SUCCESS in 0s |
mnietoji
added
ready-review
|
recheck |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/160c2efa99e5423597fe38340a7365ae ✔️ noop SUCCESS in 0s |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/db9dc39a0fe24eb1ab2730dda6867641 ✔️ noop SUCCESS in 0s |
|
rdoproject.org/github-check is failing because there is a dependency with this PR in ci-framework. I need to merge in first place ci-framework PR and then this architecture PR |
|
waiting on openstack-k8s-operators/ci-framework#3476 |
|
recheck |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/b0b6ef44390345e0b5beb4a24e7df0a8 ✔️ noop SUCCESS in 0s |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/8a64eca3dd664cab9c02755796875f0f ✔️ noop SUCCESS in 0s |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/c80b85483699476c9aedcc8cf0790ceb ✔️ noop SUCCESS in 0s |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/295cc4ac352847749a46d8db242e97a2 ✔️ noop SUCCESS in 0s |
|
recheck |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/217909a335e24dccb9ab19ce59bf3a65 ✔️ noop SUCCESS in 0s |
|
Thanks for this proposed contribution @mnietoji There's ~1800 lines being added in this PR but the majority of it is the same as the IPv4 versions. Please consider the following. Create an Other DTs, which have added IPv6 versions, used a similar pattern, e.g. #319 I know this will be some work, but it will be better for maintainability in the long run. I think if you give this PR to an AI assistant (e.g. Claude Code) and tell it that you want to refactor as described above it could do a lot of the work for you. Feel free to let me know if you have more questions. |
|
@mnietoji I used Claude Code to refactor please see https://github.com/fultonj/architecture/tree/nfv_ipv6_refactor Feel free to copy from the above example and then update this PR |
Yes, I second this approach. It adheres well to the DRY principle. |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/4ee3a0be16bc4341a86d11f344942fbf ✔️ noop SUCCESS in 0s |
mnietoji
force-pushed
the
nfv_ipv6
branch
2 times, most recently
from
3ea4a78 to
63d5604
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/2016c04b0fe8473f9c4dda9b55cb47c4 ✔️ noop SUCCESS in 0s |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/a1c7151e396c48489df3840582505931 ✔️ noop SUCCESS in 0s |
mnietoji
added
do-not-merge
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/93c9d62fd0ee45639b259b5de374c397 ✔️ noop SUCCESS in 0s |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/18532a3574464381b18ef43e321259bc ✔️ noop SUCCESS in 0s |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/2dc465459d2c4b8488d95434d57f5e1e ✔️ noop SUCCESS in 0s |
Created 2 new scenarios adding ipv6 to 2 already existing scenarios: * VA OVS DPDK SRIOV * DT OVS DPDK SRIOV with 2 nodesets Signed-off-by: Miguel Angel Nieto Jimenez <mnietoji@redhat.com>
3 participants
[NFV] OVS DPDK SRIOV IPV6 with 1 or 2 nodesets scenarios
Created 2 new scenarios adding ipv6 to 2 already existing scenarios: