Skip to content

Conversation

@karelyatin
Copy link
Contributor

With OCP 4.20 the task fails with:-
xfs_growfs: / is not a mounted XFS filesystem
As it's changed now:-
$ sudo df / --output=fstype
Type
overlay
$ sudo df /sysroot --output=fstype
Type
xfs

while with 4.18 it used to be:-
$ df /sysroot --output=fstype
Type
xfs
$ df / --output=fstype
Type
xfs

Changing the command to use /sysroot as path which works on both 4.20 and older OCP versions.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 7, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign rebtoor for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

amartyasinha
amartyasinha previously approved these changes Jan 7, 2026
Copy link
Contributor

@amartyasinha amartyasinha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

should work with older OCP version deployments:

$ sudo df / --output=fstype
Type
xfs
$ sudo df /sysroot --output=fstype
Type
xfs

@karelyatin karelyatin marked this pull request as draft January 7, 2026 13:28
@karelyatin
Copy link
Contributor Author

@abays mentioned in 4.20 this not working as read only
$ sudo xfs_growfs /sysroot
meta-data=/dev/sda4 isize=512 agcount=76, agsize=171712 blks
= sectsz=512 attr=2, projid32bit=1
= crc=1 finobt=1, sparse=1, rmapbt=0
= reflink=1 bigtime=1 inobtcount=1 nrext64=0
data = bsize=4096 blocks=12975867, imaxpct=25
= sunit=0 swidth=0 blks
naming =version 2 bsize=4096 ascii-ci=0, ftype=1
log =internal log bsize=4096 blocks=16384, version=2
= sectsz=512 sunit=0 blks, lazy-count=1
realtime =none extsz=4096 blocks=0, rtextents=0
xfs_growfs: XFS_IOC_FSGROWFSDATA xfsctl failed: Read-only file system

With OCP 4.20 the task fails with:-
xfs_growfs: / is not a mounted XFS filesystem
As it's changed now:-
$ sudo df / --output=fstype
Type
overlay
$ sudo df /sysroot --output=fstype
Type
xfs

while with 4.18 it used to be:-
$ df /sysroot --output=fstype
Type
xfs
$ df / --output=fstype
Type
xfs

Changing the command to use /sysroot as path which
works on both 4.20 and older OCP versions. Also run the
command with unshare --mount in seperate namespace.

Signed-off-by: Yatin Karel <ykarel@redhat.com>
@karelyatin karelyatin marked this pull request as ready for review January 8, 2026 08:16
@abays
Copy link
Contributor

abays commented Jan 8, 2026

@karelyatin: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
Test name Commit Details Required Rerun command
ci/prow/images ee69e4a link true /test images

Full PR test history. Your PR dashboard.
Details

{  error occurred handling build ci-framework-image-amd64: the build ci-framework-image-amd64 failed after 2m20s with reason DockerBuildFailed: Dockerfile build strategy has failed.}

/test images

@abays
Copy link
Contributor

abays commented Jan 8, 2026

@karelyatin: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
Test name Commit Details Required Rerun command
ci/prow/images ee69e4a link true /test images

Full PR test history. Your PR dashboard.
Details

ERROR! Failed to clone a Git repository from `https://github.com/ovirt/ovirt-ansible-collection`.
Starting galaxy collection install process
Process install dependency map
make: *** [Makefile:60: setup_molecule] Error 1
error: build error: building at STEP "RUN make setup_molecule USE_VENV=no": while running runtime: exit status 2}

/test images

@fultonj
Copy link
Contributor

fultonj commented Jan 8, 2026

This /lgtm let's just get past the unrelated images check issue

@abays
Copy link
Contributor

abays commented Jan 8, 2026

@karelyatin: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
Test name Commit Details Required Rerun command
ci/prow/images ee69e4a link true /test images

Full PR test history. Your PR dashboard.
Details

{  error occurred handling build ci-framework-image-amd64: the build ci-framework-image-amd64 failed after 2m20s with reason DockerBuildFailed: Dockerfile build strategy has failed.

ERROR! Failed to clone a Git repository from `https://github.com/ovirt/ovirt-ansible-collection`.
Starting galaxy collection install process
Process install dependency map
make: *** [Makefile:60: setup_molecule] Error 1
error: build error: building at STEP "RUN make setup_molecule USE_VENV=no": while running runtime: exit status 2}

Trying once again...

/test images

Copy link
Contributor

@abays abays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jan 8, 2026
@karelyatin karelyatin enabled auto-merge (rebase) January 9, 2026 04:16
@karelyatin karelyatin merged commit 3e7af9d into openstack-k8s-operators:main Jan 9, 2026
8 checks passed
@karelyatin karelyatin deleted the ocp_growfs branch January 9, 2026 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants