-
Notifications
You must be signed in to change notification settings - Fork 144
[libvirt_manager] Use /sysroot as path with xfs_growfs #3585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
should work with older OCP version deployments:
$ sudo df / --output=fstype
Type
xfs
$ sudo df /sysroot --output=fstype
Type
xfs
|
@abays mentioned in 4.20 this not working as read only |
With OCP 4.20 the task fails with:- xfs_growfs: / is not a mounted XFS filesystem As it's changed now:- $ sudo df / --output=fstype Type overlay $ sudo df /sysroot --output=fstype Type xfs while with 4.18 it used to be:- $ df /sysroot --output=fstype Type xfs $ df / --output=fstype Type xfs Changing the command to use /sysroot as path which works on both 4.20 and older OCP versions. Also run the command with unshare --mount in seperate namespace. Signed-off-by: Yatin Karel <ykarel@redhat.com>
/test images |
/test images |
|
This /lgtm let's just get past the unrelated images check issue |
Trying once again... /test images |
abays
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
With OCP 4.20 the task fails with:-
xfs_growfs: / is not a mounted XFS filesystem
As it's changed now:-
$ sudo df / --output=fstype
Type
overlay
$ sudo df /sysroot --output=fstype
Type
xfs
while with 4.18 it used to be:-
$ df /sysroot --output=fstype
Type
xfs
$ df / --output=fstype
Type
xfs
Changing the command to use /sysroot as path which works on both 4.20 and older OCP versions.