Skip to content

Remove duplicate code across test-operator #377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-bot merged 2 commits into from
Dec 17, 2025
Merged

Remove duplicate code across test-operator #377

openshift-merge-bot merged 2 commits into from
Dec 17, 2025
+313 −315

Conversation

@kstrenkova
Copy link
Contributor

@kstrenkova kstrenkova commented Dec 9, 2025 •
edited
Loading

This change is part of the effort to refactor test-operator code and reduce duplicate code to make adding new resources easier.

Assited-by: Claude AI

@openshift-ci
Copy link

openshift-ci bot commented Dec 9, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the approved label Dec 9, 2025
@kstrenkova kstrenkova force-pushed the refactor-duplicate-code branch from 146c629 to 2793b1c Compare December 9, 2025 15:16
@softwarefactory-project-zuul
Copy link

softwarefactory-project-zuul bot commented Dec 9, 2025

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/0b8de32f98e24304b47523539401d995

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 41m 06s
❌ podified-multinode-edpm-deployment-crc-test-operator FAILURE in 1h 30m 10s

@kstrenkova kstrenkova force-pushed the refactor-duplicate-code branch from 2793b1c to 8554577 Compare December 11, 2025 14:32
@softwarefactory-project-zuul
Copy link

softwarefactory-project-zuul bot commented Dec 11, 2025

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/fb00ae89664045f192e802e20d231861

❌ openstack-k8s-operators-content-provider FAILURE in 5m 55s
⚠️ podified-multinode-edpm-deployment-crc-test-operator SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

@kstrenkova
Remove duplicate code across test-operator
ea31194 
This change is part of the effort to refactor test-operator code
and reduce duplicate code to make adding new resources easier.
@kstrenkova kstrenkova force-pushed the refactor-duplicate-code branch 3 times, most recently from 16540dd to e1fd8ed Compare December 16, 2025 12:27
@kstrenkova kstrenkova marked this pull request as ready for review December 16, 2025 12:28
@openshift-ci openshift-ci bot requested review from arxcruz and stuggi December 16, 2025 12:28
@kstrenkova
Copy link
Contributor Author

kstrenkova commented Dec 16, 2025

I have tested the webhook validations and they seem to work correctly. I have also checked most of the parameters for tempest with the new functions and fixed issues I have found. It should be safe to merge now, but I would appreciate any review 😄

@kstrenkova
Refactor test-operator webhooks
40d76c2 
Each resource type has its own webhook and some warnings and
errors are across all 4 resource types. This change tries to
unify creating warnings and errors, so in case there is a new
resource type it will be easier to include it.
@kstrenkova kstrenkova force-pushed the refactor-duplicate-code branch from e1fd8ed to 40d76c2 Compare December 17, 2025 11:02
@openshift-ci openshift-ci bot added the lgtm label Dec 17, 2025
@openshift-ci
Copy link

openshift-ci bot commented Dec 17, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adrianfusco, kstrenkova

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 76870c3 into openstack-k8s-operators:main Dec 17, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adrianfusco adrianfusco adrianfusco approved these changes

@arxcruz arxcruz Awaiting requested review from arxcruz

@stuggi stuggi Awaiting requested review from stuggi

Assignees

@adrianfusco adrianfusco

Labels

approved lgtm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kstrenkova @adrianfusco