DNS Info Modules #40
DNS Info Modules #40
Conversation
![otc-zuul[bot]](https://avatars.githubusercontent.com/in/11628?s=60&v=4){kind=small}
|
|
||
| # Filter data by deleting all entries without the right criteria | ||
| i = 0 | ||
| while i < len(data): |
There was a problem hiding this comment.
double loop (and popping from array) is not good. Merge this into prev loop
There was a problem hiding this comment.
Do you have an Idea how I can merge that into the previous loop?
And why is that bad? Those aren't double loops, the runtime should be still linear O(n).
@gtema
|
|
||
| # Filter data by deleting all entries without the right criteria | ||
| i = 0 | ||
| while i < len(data): |
plugins/modules/dns_zone_info.py
Outdated
| query = {} | ||
|
|
||
| if self.params['zone_type']: | ||
| query['zone_type'] = self.params['zone_type'] |
There was a problem hiding this comment.
lots of filters are already suported by API (https://docs.openstack.org/api-ref/dns/?expanded=list-floatingip-s-ptr-record-detail,list-recordsets-in-a-zone-detail,list-zones-detail#list-zones), please pass as much as possible into list
There was a problem hiding this comment.
@gtema I looked at our doc under https://docs.otc.t-systems.com/en-us/api/dns/dns_api_62002.html and there nothing of that is written. WIll change that
Update: When requesting with e.g. the Query Parameter "name" which is supported according to the OpenStack Docu, it doesn't work.
"msg": "Invalid query params: name"
|
|
||
| # Filter data by deleting all entries without the right criteria | ||
| i = 0 | ||
| while i < len(data): |
|
Don't merge this yet. |
|
recheck |
3 similar comments
|
recheck |
|
recheck |
|
recheck |
|
recheck |
2 similar comments
|
recheck |
|
recheck |
5 participants
No description provided.