-
Notifications
You must be signed in to change notification settings - Fork 2.8k
[GPU] add format::b_fs_yx_fsv4 to onednn::conv support list #32435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GPU] add format::b_fs_yx_fsv4 to onednn::conv support list #32435
Conversation
| network.set_input_data("input", input_mem); | ||
| network.set_input_data("weights", weights_mem); | ||
| network.execute(); | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you reuse existing case? I think there should be something we can use by parametrization
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no test with parameterization for onednn. In almost test, it uses 'force_implementations()' func to set format to issue node. but the test for this issue needs to check has_impl due to it doesn't call the test_format() in add_required_reorders pass. test_format() occurs this issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description of the issue(symptom, root-cause, how it was resolved)
The code and line that caused this issue (if it is not changed directly)
Reproduction step and snapshot (if applicable. Do not attach for customer model)
Problematic graph
cldnn_program_1_15_prepare_buffer_fusing.graph

cldnn_program_1_16_add_required_reorders.graph

Checklist
-> In add_required_reorder pass, this convolution should be chosen wrong format via test_format() to reproduce the issue.
Tickets: