Skip to content

Conversation

@sungeunk
Copy link
Contributor

@sungeunk sungeunk commented Oct 16, 2025

Description of the issue(symptom, root-cause, how it was resolved)

  • This issue can be reproduced on the machine which the onednn is working.
  • It cannot create the onednn primitive with this error msg: "Check 'shape_consistent' failed at src/plugins/intel_gpu/src/graph/impls/onednn/convolution_onednn.cpp:264: [GPU] Input shape and output shape of weight reorder should be same."
  • root-cause: At add_required_reorders pass, b_fs_fsv4 is chosen for input0 via find_data_format(). b_fs_fsv4 is not in supported list for onednn::conv. it chooses bfzyx for in/out of conv via test_format().

The code and line that caused this issue (if it is not changed directly)

  • src/plugins/intel_gpu/src/graph/impls/onednn/convolution_onednn.cpp (test_format)

Reproduction step and snapshot (if applicable. Do not attach for customer model)

  • reproducer is attached in the ticket.

Problematic graph

cldnn_program_1_15_prepare_buffer_fusing.graph
image

cldnn_program_1_16_add_required_reorders.graph
image

Checklist

  • Is it a proper fix? (not a workaround)
  • Did you include test case for this fix, if necessary?
  • Did you review existing test that can be extended to cover this scenario? Which test did you review?
    -> In add_required_reorder pass, this convolution should be chosen wrong format via test_format() to reproduce the issue.

Tickets:

  • 174951

@sungeunk sungeunk added the category: GPU OpenVINO GPU plugin label Oct 16, 2025
@sungeunk sungeunk requested review from a team as code owners October 16, 2025 07:09
@sungeunk sungeunk requested a review from isanghao October 20, 2025 01:59
network.set_input_data("input", input_mem);
network.set_input_data("weights", weights_mem);
network.execute();
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you reuse existing case? I think there should be something we can use by parametrization

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no test with parameterization for onednn. In almost test, it uses 'force_implementations()' func to set format to issue node. but the test for this issue needs to check has_impl due to it doesn't call the test_format() in add_required_reorders pass. test_format() occurs this issue.

@p-durandin p-durandin added this to the 2025.4 milestone Oct 20, 2025
@sungeunk sungeunk requested a review from isanghao October 20, 2025 06:07
Copy link
Contributor

@isanghao isanghao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@isanghao isanghao added this pull request to the merge queue Oct 20, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 20, 2025
@p-durandin p-durandin added this pull request to the merge queue Oct 20, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 20, 2025
@p-durandin p-durandin added this pull request to the merge queue Oct 20, 2025
Merged via the queue into openvinotoolkit:master with commit ec6a8d2 Oct 20, 2025
187 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category: GPU OpenVINO GPU plugin Code Freeze

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants