Skip to content

Conversation

sgbihu
Copy link
Contributor

@sgbihu sgbihu commented Oct 17, 2025

Details:

  • The empty const makes load memory throw exception.
image

Tickets:

@sgbihu sgbihu requested a review from a team as a code owner October 17, 2025 06:44
@github-actions github-actions bot added the category: ONNX FE OpenVINO ONNX FrontEnd label Oct 17, 2025
@sgbihu sgbihu requested a review from Copilot October 20, 2025 03:49
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes an issue where empty constants with zero-size external data were causing OpenVINO to throw exceptions during memory loading. The fix handles edge cases for zero-size external data in ONNX models.

  • Added validation logic to properly handle zero-size external data scenarios
  • Improved scalar tensor detection to differentiate between empty tensors and scalars
  • Added test coverage for the zero-size external data edge case

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
src/frontends/onnx/frontend/src/utils/tensor_external_data.cpp Updated validation logic for external memory data loading to handle zero-size cases
src/frontends/onnx/frontend/src/core/tensor.hpp Refined scalar tensor detection and external data validation
src/frontends/onnx/tests/onnx_reader_external_data.cpp Added test case for zero-size external data scenario
src/frontends/onnx/tests/models/external_data/external_data_0_size.prototxt Added test model with zero-size external data

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@sgbihu sgbihu requested a review from Copilot October 20, 2025 04:41
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@sgbihu sgbihu requested a review from Copilot October 20, 2025 05:12
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@sgbihu sgbihu requested a review from Copilot October 20, 2025 05:24
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@sgbihu sgbihu requested review from Copilot and mvafin October 20, 2025 05:25
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@sgbihu sgbihu requested a review from Copilot October 20, 2025 05:30
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@mvafin mvafin added this to the 2025.4 milestone Oct 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category: ONNX FE OpenVINO ONNX FrontEnd Code Freeze

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants