Skip to content

Conversation

@a-gave
Copy link
Contributor

@a-gave a-gave commented May 21, 2025

No description provided.

@codecov
Copy link

codecov bot commented May 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.23%. Comparing base (5e65dec) to head (30458ee).
Report is 252 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1404      +/-   ##
==========================================
+ Coverage   80.75%   90.23%   +9.48%     
==========================================
  Files          15       14       -1     
  Lines         977     1219     +242     
==========================================
+ Hits          789     1100     +311     
+ Misses        188      119      -69     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@efahl
Copy link
Contributor

efahl commented May 28, 2025

Is it working now? I'm getting 404s...

$ curl -v https://sysupgrade.antennine.org/json/v1/overview.json
> GET /json/v1/overview.json HTTP/2
> Host: sysupgrade.antennine.org
> User-Agent: curl/8.10.1
> Accept: */*
>
< HTTP/2 404
< server: nginx/1.22.1
< date: Wed, 28 May 2025 18:13:28 GMT
< content-length: 0
<

@aparcar
Copy link
Member

aparcar commented Jun 2, 2025

Seems to work?

@aparcar aparcar merged commit 7fbdc63 into openwrt:main Jun 2, 2025
5 checks passed
@a-gave
Copy link
Contributor Author

a-gave commented Jun 2, 2025

Is it working now? I'm getting 404s...

Hi, thanks!
The server is working, I didn't noticed that those api are not exposed, but they seem not be used internally so building firmwares works.
The other day I did a setup of a local server from a clean clone, with podman-compose, but also there seems that /tmp/public/json and overview.json are not created. I'll try to look at it better much probably after 11 june!

@efahl
Copy link
Contributor

efahl commented Jun 2, 2025

auc and owut both use downloads from both api/v1 and json/v1, the LuCI app only does requests against api/v1.

$ uci set attendedsysupgrade.server.url="https://sysupgrade.antennine.org"

$ owut check
owut - OpenWrt Upgrade Tool 2025.05.12~8353c4e9-r1 (/usr/bin/owut)
ERROR: Response status 404 while downloading
  https://sysupgrade.antennine.org/json/v1/overview.json

@a-gave
Copy link
Contributor Author

a-gave commented Jun 12, 2025

auc and owut both use downloads from both api/v1 and json/v1, the LuCI app only does requests against api/v1.

Hi, sorry there was an old config in the Caddyfile that was pointing to a non existing directory

	#handle_path /json* {
	#	root * /builder/public/json
	#	file_server
	#}

Tested briefly on a openwrt-24.10.1-ath79-nand-meraki_mr18 and works as expected (running owut check and owut upgrade)

@efahl
Copy link
Contributor

efahl commented Jun 12, 2025

Looking better! All my owut check/dump tests appear to be working correctly now, but I can't get it to do a build. I'm getting errors about non-existent imagebuilder containers:

podman.errors.exceptions.APIError: 500 Server Error: Internal Server Error (ghcr.io/openwrt/imagebuilder-alpine:ath79-generic-openwrt-24.10: image not known)
podman.errors.exceptions.APIError: 500 Server Error: Internal Server Error (ghcr.io/openwrt/imagebuilder-alpine:mediatek-filogic-openwrt-24.10: image not known)
podman.errors.exceptions.APIError: 500 Server Error: Internal Server Error (ghcr.io/openwrt/imagebuilder-alpine:mediatek-mt7622-openwrt-24.10: image not known)
podman.errors.exceptions.APIError: 500 Server Error: Internal Server Error (ghcr.io/openwrt/imagebuilder-alpine:x86-64-master: image not known)
podman.errors.exceptions.APIError: 500 Server Error: Internal Server Error (ghcr.io/openwrt/imagebuilder-alpine:x86-64-openwrt-24.10: image not known)

I can't find the https://ghcr.io/openwrt/imagebuilder-alpine repo. If I delete the -alpine in the container location, I can load them up without issue.

Is the the -alpine private or something?

$ podman run -it ghcr.io/openwrt/imagebuilder-alpine:x86-64-openwrt-24.10
Trying to pull ghcr.io/openwrt/imagebuilder-alpine:x86-64-openwrt-24.10...
Error: internal error: unable to copy from source docker://ghcr.io/openwrt/imagebuilder-alpine:x86-64-openwrt-24.10: initializing source docker://ghcr.io/openwrt/imagebuilder-alpine:x86-64-openwrt-24.10: Requesting bearer token: received unexpected HTTP status: 403 Forbidden

vs

$ podman run -it ghcr.io/openwrt/imagebuilder:x86-64-openwrt-24.10
Trying to pull ghcr.io/openwrt/imagebuilder:x86-64-openwrt-24.10...
Getting image source signatures
Copying blob 8e3a365d41e1 done   |
Copying blob 014ac6453c34 done   |
Copying blob 1bcaaa4e2341 done   |
Copying blob 31369e20b98e done   |
Copying blob 64eaae1619b6 done   |
Copying blob 70c294cdc1db done   |
Copying blob af756eab433c done   |
Copying blob 0e531a2c65d2 done   |
Copying blob 4f4fb700ef54 done   |
Copying blob 702dc094c1f5 done   |
Copying blob 7ae9596c261a done   |
Copying blob 4f4fb700ef54 skipped: already exists
Copying config 024879809d done   |
Writing manifest to image destination
buildbot@f297a1c82082:~$

@a-gave
Copy link
Contributor Author

a-gave commented Jun 16, 2025

Hi, sorry, SNAPSHOT podman images were missing, they are available now.
I'm building the imagebuilders images basing them on alpine to reduce the disk space used and because it results faster to build (aka downloading all tar.xz archives from the openwrt download server, than pulling all podman images from registries)
I started trying to upstream it here openwrt/docker#169
I manually checked that sha256_unsigned of firmware images are the same with those produced by the original server https://sysupgrade.openwrt.org

@efahl
Copy link
Contributor

efahl commented Jun 16, 2025

I started trying to upstream it here openwrt/docker#169

Oh, that's nice! The much smaller containers should reduce bandwidth use a bunch.

I'm still getting a 500 on some of the SNAPSHOT files, though.

ERROR: Response status 500 while downloading
   https://sysupgrade.openwrt.org/json/v1/snapshots/targets/x86/64/index.json  

Aha, just remembered, you need to update to that latest ASU fix on your server:
55baae2

@a-gave
Copy link
Contributor Author

a-gave commented Jun 16, 2025

Aha, just remembered, you need to update to that latest ASU fix on your server: 55baae2

Had seen but then I forgot about that recent commit sorry, updated!

@efahl
Copy link
Contributor

efahl commented Jun 17, 2025

My tests are all working with owut. Here's a quick once-over:

uci set attendedsysupgrade.server.url="https://sysupgrade.antennine.org"
owut download < a bunch of variants >

where a bunch of variants are

Device                               Version
x86/64:generic                       24.10.1
x86/64:generic                       24.10-snapshot
x86/64:generic                       snapshot
ath79/generic:tplink,archer-c7-v4    24.10-snapshot
mediatek/mt7622:linksys,e8450-ubi    24.10-snapshot
mediatek/filogic:zyxel,nwa50ax-pro   24.10-snapshot
lantiq/xrx200:bt,homehub-v5a         snapshot

I attempted to use your alpine containers on my local ASU server,

$ cat .env
...
BASE_CONTAINER="ghcr.io/openwrt/imagebuilder-alpine"

but it fails out with a 403. Is this possible or do I need some credentials? (Or do I just need to wait for your PR to get merged and then things will open up?)

$ podman run -ti ghcr.io/openwrt/imagebuilder-alpine:lantiq-xrx200-openwrt-24.10
Trying to pull ghcr.io/openwrt/imagebuilder-alpine:lantiq-xrx200-openwrt-24.10...
Error: initializing source docker://ghcr.io/openwrt/imagebuilder-alpine:lantiq-xrx200-openwrt-24.10: Requesting bearer token: invalid status code from registry 403 (Forbidden)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants