ddns-scripts: add beget.com api support #28102
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LogExE
force-pushed
the
feature_beget_ddns
branch
2 times, most recently
from
6911fb5 to
2ef2362
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 6 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
net/ddns-scripts/Makefile
Outdated
| rm $(1)/usr/share/ddns/default/route53-v1.json | ||
| rm $(1)/usr/share/ddns/default/cnkuai.cn.json | ||
| rm $(1)/usr/share/ddns/default/gandi.net.json | ||
| rm $(1)/usr/share/ddns/default/beget.com.json |
There was a problem hiding this comment.
This line contains inconsistent indentation - it uses spaces instead of tabs. The rest of the Makefile uses tabs for indentation. This line should use a tab character at the beginning to match the surrounding code style.
Suggested change
| rm $(1)/usr/share/ddns/default/beget.com.json | |
| rm $(1)/usr/share/ddns/default/beget.com.json |
Member
|
On top of all the other suggestions, you need to add a commit message describing the changes and use your real name both as author and sign-off. |
GeorgeSapkin
changed the title
LogExE
force-pushed
the
feature_beget_ddns
branch
4 times, most recently
from
fc70572 to
daee801
Compare
The Beget API provider was implemented according to https://beget.com/en/kb/api/dns-administration-functions Signed-off-by: Vladimir Tkachev <awesome149712@gmail.com>
LogExE
force-pushed
the
feature_beget_ddns
branch
from
daee801 to
63675dd
Compare
Member
|
Thanks merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📦 Package Details
Maintainer: @feckert (?)
Description:
This PR adds support for changing DNS records through beget.com API.
✅ Formalities