Skip to content

Conversation

@mvz
Copy link
Contributor

@mvz mvz commented Jan 31, 2023

It's suppress, not supress.

It's suppress, not supress.
@boblail
Copy link
Member

boblail commented Feb 7, 2023

👍 LGTM

It's a break change. Should we bump the gem to 0.12.0 also with this PR? — maybe even start a CHANGES.md file to mention it?

@boblail boblail requested review from kobsy and lukebooth February 7, 2023 00:15
@mvz
Copy link
Contributor Author

mvz commented Feb 7, 2023

Should we bump the gem to 0.12.0 also with this PR? — maybe even start a CHANGES.md file to mention it?

That makes sense. Would you like me to add a changelog in this PR?

@kobsy
Copy link
Member

kobsy commented Feb 8, 2023

I agree the changes look good AND that we should bump the version since it's a breaking change. 👍 Would you mind adding the changelog, @mvz? And thanks for catching and correcting this spelling mistake! 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants