adding metrics-require-rbac flag, metrics-secure validation logic #116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acornett21
force-pushed
the
add_rbac_metrics_auth
branch
2 times, most recently
from
97e1607 to
37393fc
Compare
… corresponding scaffolding logic Signed-off-by: Adam D. Cornett <adc@redhat.com>
acornett21
force-pushed
the
add_rbac_metrics_auth
branch
from
37393fc to
0e25d62
Compare
|
/cherry-pick release-v1.36 |
|
@acornett21: new pull request created: #119 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
Adding in
metrics-require-rbacto enable authn/authz rbac runtime and scaffolding logic. This aligns with the work done in operator-sdk k8 1.30 work.Motivation for the change:
This was missed in the initial k8s 1.30 work, since the auth tests had been modified for kube builder 3.15.0.