fix: set proper host header before proxying the request #177
+20
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jason Joo <hblzxsj@gmail.com>
jasonjoo2010
force-pushed
the
fix/hostname
branch
from
d0d7e9d to
0027ff2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
This PR updates the HTTP Host header to match the domain name configured in kubeconfig. This change ensures that requests are correctly routed and authenticated when accessing the Kubernetes API server, especially in environments where the API server is behind a proxy or load balancer that relies on the Host header for routing.
Motivation for the change:
The API server may be accessed through various proxies or load balancers through a domain name in kubeconfig. If the Host header does not match the expected domain name, requests may be rejected or misrouted. By aligning the Host header with the domain name in kubeconfig, we ensure that requests are properly authenticated and routed, improving reliability and compatibility with different Kubernetes setups.